Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 213883003: Revert of Send AXLayoutComplete even when document hasn't finished loading yet. (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
Reviewers:
esprehn, dmazzoni, eseidel
CC:
blink-reviews, aboxhall, abarth-chromium
Visibility:
Public.

Description

Revert of Send AXLayoutComplete even when document hasn't finished loading yet. (https://codereview.chromium.org/199693003/) Reason for revert: Causes content_browertests to fail: [ RUN ] DumpAccessibilityTreeTest.AccessibilityModalDialogInIframeOpened Testing: E:\b\build\slave\Win7_Tests\build\src\content\test\data\accessibility\modal-dialog-in-iframe-opened.html c:\b\build\slave\win-latest-rel\build\src\content\browser\accessibility\dump_accessibility_tree_browsertest.cc(209): error: Value of: is_different Actual: true Expected: false * Line Expected - ---- -------- 1 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE 2 IA2_ROLE_SECTION READONLY 3 ROLE_SYSTEM_STATICTEXT name='Test for modal dialog opened in an iframe. ' 4 ROLE_SYSTEM_CLIENT FOCUSABLE 5 IA2_ROLE_SCROLL_PANE 6 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE 7 ROLE_SYSTEM_DIALOG READONLY 8 ROLE_SYSTEM_STATICTEXT name='Text in the dialog.' * 9 ROLE_SYSTEM_SCROLLBAR 10 <-- End-of-file --> Actual ------ ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE IA2_ROLE_SECTION READONLY ROLE_SYSTEM_STATICTEXT name='Test for modal dialog opened in an iframe. ' ROLE_SYSTEM_CLIENT FOCUSABLE IA2_ROLE_SCROLL_PANE ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ROLE_SYSTEM_DIALOG READONLY ROLE_SYSTEM_STATICTEXT name='Text in the dialog.' Original issue's description: > Send AXLayoutComplete even when document hasn't finished loading yet. > > Because these notifications only got sent if the corresponding AXObject > already existed, they were effectively never sent before the first > load complete notification. This change creates the AXObject for the > document element after the first layout, allowing future notifications too. > > BUG=353067 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170085 TBR=eseidel@chromium.org,esprehn@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=353067 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -75 lines) Patch
D LayoutTests/http/tests/accessibility/slow-document-load.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/http/tests/accessibility/slow-document-load-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/http/tests/accessibility/slow-loading-script.cgi View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/accessibility/AXObjectCache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXObjectCache.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
enne (OOO)
Created Revert of Send AXLayoutComplete even when document hasn't finished loading yet.
6 years, 9 months ago (2014-03-27 00:07:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/213883003/1
6 years, 9 months ago (2014-03-27 00:08:00 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 00:08:24 UTC) #3
Message was sent while issue was closed.
Change committed as 170112

Powered by Google App Engine
This is Rietveld 408576698