Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Side by Side Diff: chrome/browser/tab_contents/tab_util.cc

Issue 21388003: Move routing to RenderFrameHost instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move global map to .cc file. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/browser/download/download_request_handle.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tab_contents/tab_util.h" 5 #include "chrome/browser/tab_contents/tab_util.h"
6 6
7 #include "chrome/browser/extensions/extension_service.h" 7 #include "chrome/browser/extensions/extension_service.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h" 9 #include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h"
10 #include "chrome/common/chrome_switches.h" 10 #include "chrome/common/chrome_switches.h"
11 #include "content/public/browser/render_frame_host.h"
11 #include "content/public/browser/render_view_host.h" 12 #include "content/public/browser/render_view_host.h"
12 #include "content/public/browser/site_instance.h" 13 #include "content/public/browser/site_instance.h"
13 #include "content/public/browser/web_contents.h" 14 #include "content/public/browser/web_contents.h"
14 #include "url/gurl.h" 15 #include "url/gurl.h"
15 16
17 using content::RenderFrameHost;
16 using content::RenderViewHost; 18 using content::RenderViewHost;
17 using content::SiteInstance; 19 using content::SiteInstance;
18 using content::WebContents; 20 using content::WebContents;
19 21
20 namespace tab_util { 22 namespace tab_util {
21 23
22 content::WebContents* GetWebContentsByID(int render_process_id, 24 content::WebContents* GetWebContentsByID(int render_process_id,
23 int render_view_id) { 25 int render_view_id) {
24 RenderViewHost* render_view_host = 26 RenderViewHost* render_view_host =
25 RenderViewHost::FromID(render_process_id, render_view_id); 27 RenderViewHost::FromID(render_process_id, render_view_id);
26 if (!render_view_host) 28 if (!render_view_host) {
27 return NULL; 29 RenderFrameHost* render_frame_host =
30 RenderFrameHost::FromID(render_process_id, render_view_id);
31 if (!render_frame_host)
32 return NULL;
33
34 return WebContents::FromRenderViewHost(
35 render_frame_host->GetRenderViewHost());
36 }
28 37
29 return WebContents::FromRenderViewHost(render_view_host); 38 return WebContents::FromRenderViewHost(render_view_host);
30 } 39 }
31 40
32 SiteInstance* GetSiteInstanceForNewTab(Profile* profile, 41 SiteInstance* GetSiteInstanceForNewTab(Profile* profile,
33 const GURL& url) { 42 const GURL& url) {
34 // If url is a WebUI or extension, we need to be sure to use the right type 43 // If url is a WebUI or extension, we need to be sure to use the right type
35 // of renderer process up front. Otherwise, we create a normal SiteInstance 44 // of renderer process up front. Otherwise, we create a normal SiteInstance
36 // as part of creating the tab. 45 // as part of creating the tab.
37 ExtensionService* service = profile->GetExtensionService(); 46 ExtensionService* service = profile->GetExtensionService();
38 if (ChromeWebUIControllerFactory::GetInstance()->UseWebUIForURL( 47 if (ChromeWebUIControllerFactory::GetInstance()->UseWebUIForURL(
39 profile, url) || 48 profile, url) ||
40 (service && 49 (service &&
41 service->extensions()->GetHostedAppByURL(url))) { 50 service->extensions()->GetHostedAppByURL(url))) {
42 return SiteInstance::CreateForURL(profile, url); 51 return SiteInstance::CreateForURL(profile, url);
43 } 52 }
44 53
45 // We used to share the SiteInstance for same-site links opened in new tabs, 54 // We used to share the SiteInstance for same-site links opened in new tabs,
46 // to leverage the in-memory cache and reduce process creation. It now 55 // to leverage the in-memory cache and reduce process creation. It now
47 // appears that it is more useful to have such links open in a new process. 56 // appears that it is more useful to have such links open in a new process.
48 return NULL; 57 return NULL;
49 } 58 }
50 59
51 } // namespace tab_util 60 } // namespace tab_util
OLDNEW
« no previous file with comments | « no previous file | content/browser/download/download_request_handle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698