Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2138793002: Add NTPSnippets to DataUse.Service.Types histogram suffix (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
Steven Holte
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NTPSnippets to DataUse.Service.Types histogram suffix The NTPSnippets entry was originally added in https://codereview.chromium.org/1875073002, which added an enum entry in histograms.xml. Turns out there's also a suffix that needs to be updated. BUG=601380 Committed: https://crrev.com/353317e96cf335ebc2b4fc93cae387fec0d0ab58 Cr-Commit-Position: refs/heads/master@{#405455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Marc Treib
PTAL!
4 years, 5 months ago (2016-07-11 15:04:46 UTC) #3
Steven Holte
lgtm
4 years, 5 months ago (2016-07-13 18:45:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138793002/1
4 years, 5 months ago (2016-07-14 08:26:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 09:21:58 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 09:22:08 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 09:24:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/353317e96cf335ebc2b4fc93cae387fec0d0ab58
Cr-Commit-Position: refs/heads/master@{#405455}

Powered by Google App Engine
This is Rietveld 408576698