Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2138783002: TestCodeFlushingIncrementalScavenge should not allocate on black pages. (Closed)

Created:
4 years, 5 months ago by Hannes Payer (out of office)
Modified:
4 years, 5 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

TestCodeFlushingIncrementalScavenge should not allocate on black pages. BUG= Committed: https://crrev.com/8551daee4da7e8d3dc31199867921d47e59efd5d Cr-Commit-Position: refs/heads/master@{#37648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Lippautz
lgtm
4 years, 5 months ago (2016-07-11 14:49:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138783002/1
4 years, 5 months ago (2016-07-11 14:50:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 15:17:25 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 15:17:27 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 15:20:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8551daee4da7e8d3dc31199867921d47e59efd5d
Cr-Commit-Position: refs/heads/master@{#37648}

Powered by Google App Engine
This is Rietveld 408576698