tools/android/loading/sandwich_swr.py - Issue 2138713002: sandwich: Fix some trivial failures on SWR benchmark runs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/loading/sandwich_swr.py

Issue 2138713002: sandwich: Fix some trivial failures on SWR benchmark runs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Egor's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/loading/sandwich_swr.py

diff --git a/tools/android/loading/sandwich_swr.py b/tools/android/loading/sandwich_swr.py

index a902f4da851bcc1a0535526897dabad8f71a116c..e6b3736b50bd93b844295b8b9ed9180ffad89ef5 100644

--- a/tools/android/loading/sandwich_swr.py

+++ b/tools/android/loading/sandwich_swr.py

@@ -96,6 +96,8 @@ def _BuildBenchmarkCache(

cache_backend.DeleteKey(request.url)

delete_count += 1

continue

+ if not request.HasReceivedResponse():

+ continue

if request.url in urls_to_enable_swr:

request.SetHTTPResponseHeader(

'cache-control', 'max-age=0,stale-while-revalidate=315360000')

« no previous file with comments | « tools/android/loading/request_track.py ('k') | tools/android/loading/sandwich_utils.py » ('j') | no next file with comments »