Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 2138703003: [git-map-branches] Show CL status verbatim. (Closed)

Created:
4 years, 5 months ago by asanka
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[git-map-branches] Show CL status verbatim. git-map-branches -v -v -v currently indicates the status of the CL using a color. This change adds the status string alongside the CL to match the output of 'git-cl status'. $ git map-branches -v -v -v Before: A 354ccf6 [ ahead 1 ] https://codereview... B e701150 [ ahead 1 ] https://codereview... C * 094cedd [ ahead 1 ] https://codereview... After: A 354ccf6 [ ahead 1 ] https://codereview... (commit) B e701150 [ ahead 1 ] https://codereview... (lgtm) C * 094cedd [ ahead 1 ] https://codereview... (waiting) R=dpranke@chromium.org BUG=none Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/97f3949a4d5fcc798b0fc771cef879dae98949af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M git_map_branches.py View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
asanka
m
4 years, 5 months ago (2016-07-11 18:36:04 UTC) #1
asanka
PTAL?
4 years, 5 months ago (2016-07-11 18:36:44 UTC) #2
Dirk Pranke
This seems reasonable to me, but I don't use this script and so don't really ...
4 years, 5 months ago (2016-07-11 22:53:33 UTC) #4
asanka
On 2016/07/11 at 22:53:33, dpranke wrote: > This seems reasonable to me, but I don't ...
4 years, 5 months ago (2016-07-12 13:34:33 UTC) #5
anatoly techtonik
Useful change, I was about to see if I can implement this myself, especially status ...
4 years, 5 months ago (2016-07-16 06:43:08 UTC) #6
iannucci
this lgtm! sorry for the delay, I was traveling!
4 years, 5 months ago (2016-07-19 01:09:14 UTC) #7
asanka
On 2016/07/19 at 01:09:14, iannucci wrote: > this lgtm! > > sorry for the delay, ...
4 years, 5 months ago (2016-07-19 01:12:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138703003/1
4 years, 5 months ago (2016-07-19 01:12:45 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 01:16:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/97f3949a4d5fcc...

Powered by Google App Engine
This is Rietveld 408576698