Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.h

Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/geolocation/Geolocation.h
diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.h b/third_party/WebKit/Source/modules/geolocation/Geolocation.h
index 8c41a8b9205ed15d0bc341523a6f20b7792cee7a..f2883bc3a7b3846d682c3a38f696c6b0013df9d5 100644
--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.h
+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.h
@@ -29,7 +29,7 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "core/dom/ContextLifecycleObserver.h"
-#include "core/page/PageLifecycleObserver.h"
+#include "core/page/PageVisibilityObserver.h"
#include "modules/ModulesExport.h"
#include "modules/geolocation/GeoNotifier.h"
#include "modules/geolocation/GeolocationWatchers.h"
@@ -55,7 +55,7 @@ class MODULES_EXPORT Geolocation final
: public GarbageCollectedFinalized<Geolocation>
, public ScriptWrappable
, public ContextLifecycleObserver
- , public PageLifecycleObserver {
+ , public PageVisibilityObserver {
DEFINE_WRAPPERTYPEINFO();
USING_GARBAGE_COLLECTED_MIXIN(Geolocation);
public:
@@ -63,7 +63,7 @@ public:
~Geolocation();
DECLARE_VIRTUAL_TRACE();
- // Inherited from ContextLifecycleObserver AND PageLifecycleObserver.
+ // Inherited from ContextLifecycleObserver AND PageVisibilityObserver.
void contextDestroyed() override;
Document* document() const;
@@ -97,7 +97,7 @@ public:
// Discards the notifier if it is a oneshot because it timed it.
void requestTimedOut(GeoNotifier*);
- // Inherited from PageLifecycleObserver.
+ // Inherited from PageVisibilityObserver.
void pageVisibilityChanged() override;
private:

Powered by Google App Engine
This is Rietveld 408576698