Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2138663002: Revert of Add effect node support in PaintArtifactCompositor for layer list mode [4/4] (Closed)

Created:
4 years, 5 months ago by Yuki
Modified:
4 years, 5 months ago
Reviewers:
chrishtr, jbroman, trchen
CC:
jbroman, ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@pac_layer_list_step_3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add effect node support in PaintArtifactCompositor for layer list mode [4/4] (patchset #7 id:120001 of https://codereview.chromium.org/2052763002/ ) Reason for revert: This CL seems making webkit_unit_tests' failures. https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/builds/8344 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/builds/8334 Original issue's description: > Add effect node support in PaintArtifactCompositor for layer list mode [4/4] > > This CL adds a local EffectStack class similar to ClipManager, that keep track > of effect state and assign generated cc effect node to layers. This is only > used for layer list mode. > > BUG=609937 > > Committed: https://crrev.com/889b2a8057be02fefc2fdd9e5deb289844f94040 > Cr-Commit-Position: refs/heads/master@{#404575} TBR=jbroman@chromium.org,chrishtr@chromium.org,trchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=609937 Committed: https://crrev.com/a86f5c887ea55c84854e4f13cf482975ee307ff4 Cr-Commit-Position: refs/heads/master@{#404622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -183 lines) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 5 chunks +2 lines, -112 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 11 chunks +21 lines, -71 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuki
Created Revert of Add effect node support in PaintArtifactCompositor for layer list mode [4/4]
4 years, 5 months ago (2016-07-11 06:58:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138663002/1
4 years, 5 months ago (2016-07-11 06:58:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 09:28:35 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 09:28:36 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 09:30:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a86f5c887ea55c84854e4f13cf482975ee307ff4
Cr-Commit-Position: refs/heads/master@{#404622}

Powered by Google App Engine
This is Rietveld 408576698