[Editing][CodeHealth] Improve result comparing in assert_selection

third_party/WebKit/LayoutTests/editing/assert_selection.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 // This file provides |assert_selection(sample, tester, expectedText)| assertion
 // to W3C test harness to write editing test cases easier.
 //
 // |sample| is an HTML fragment text which is inserted as |innerHTML|. It should
@@ skipping 562 matching lines @@
   serialize() {
     /** @type {!SampleSelection} */
     const selection = SampleSelection.fromDOMSelection(this.selection_);
     /** @type {!Serializer} */
     const serializer = new Serializer(selection);
     return serializer.serialize(this.document_);
   }
 }
 
 function assembleDescription() {
-  const RE_TEST_FUNCTION =
-      new RegExp('at Object.test \\(.*?([^/]+?):(\\d+):(\\d+)\\)');
   function getStack() {
     let stack;
     try {
       throw new Error('get line number');
     } catch (error) {
       stack = error.stack.split('\n').slice(1);
     }
     return stack
   }
+
+  const RE_IN_ASSERT_SELECTION = new RegExp('assert_selection\\.js');
   for (const line of getStack()) {
-    const match = RE_TEST_FUNCTION.exec(line);
-    if (!match)
-      continue;
-    return `${match[1]}(${match[2]})`;
+    const match = RE_IN_ASSERT_SELECTION.exec(line);
+    if (!match) {
+      const RE_LAYOUTTESTS = new RegExp('LayoutTests.*');
+      return RE_LAYOUTTESTS.exec(line);
+    }
   }
   return '';
 }
 
 /**
  * @param {string} expectedText
  */
 function checkExpectedText(expectedText) {
   /** @type {number} */
   const anchorOffset = expectedText.indexOf('^');
@@ skipping 36 matching lines @@
   } else if (typeof(tester) === 'string') {
     const strings = tester.split(' ');
     sample.document.execCommand(strings[0], false, strings[1]);
   } else {
     throw new Error(`Invalid tester: ${tester}`);
   }
   /** @type {string} */
   const actualText = sample.serialize();
   // We keep sample HTML when assertion is false for ease of debugging test
   // case.
-  if (actualText === expectedText)
+  if (actualText === expectedText) {
     sample.remove();
-  assert_equals(actualText, expectedText, description);
+  } else {
+    var comparedLength = Math.min(actualText.length, expectedText.length);

[yosin_UTC9, 2016/07/11 06:48:18]

Could you introduce mismatch(str1, str2) and mismatchLast(str1, str2) to cut
both end?

[yoichio, 2016/07/11 09:04:14]

Done.

+    var i = 0;
+    for (; i < comparedLength; ++i) {
+      if (actualText[i] !== expectedText[i])
+          break;
+    }
+
+    throw new Error(`${description}\n` +
+      `\t expected ${expectedText},\n` +
+      `\t but got  ${actualText},\n` +
+      `\t sameupto ${expectedText.substr(0,i)}`);
+  }
 }
 
 // Export symbols
 window.Sample = Sample;
 window.assert_selection = assertSelection;
 })();