chrome/browser/ui/android/autofill/autofill_popup_view_android.cc - Issue 2138643004: [Autofill] Add support for signin promo on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Issue 2138643004: [Autofill] Add support for signin promo on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aaa

Patch Set: nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

index 663bd8b4192cd476f878eb1a6532e5e2d65692fb..02bcfdd2e062c0277b689fa8b3208d63253c2f8d 100644

--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

@@ -82,7 +82,8 @@ void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {

bool deletable =

controller_->GetRemovalConfirmationText(i, nullptr, nullptr);

bool is_label_multiline =

- suggestion.frontend_id == POPUP_ITEM_ID_WARNING_MESSAGE;

+ suggestion.frontend_id == POPUP_ITEM_ID_WARNING_MESSAGE ||

+ suggestion.frontend_id == POPUP_ITEM_ID_CREDIT_CARD_SIGNIN_PROMO;

Java_AutofillPopupBridge_addToAutofillSuggestionArray(

env, data_array.obj(), i, value.obj(), label.obj(), android_icon_id,

suggestion.frontend_id, deletable, is_label_multiline);