[Autofill] Add support for signin promo on Android

chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.signin;
 
 import android.content.Context;
 import android.content.Intent;
 import android.os.Bundle;
 import android.support.annotation.IntDef;
@@ skipping 23 matching lines @@
         implements AccountSigninView.Listener, AccountSigninView.Delegate {
     private static final String TAG = "AccountSigninActivity";
     private static final String INTENT_SIGNIN_ACCESS_POINT =
             "AccountSigninActivity.SigninAccessPoint";
 
     private AccountSigninView mView;
     private ProfileDataCache mProfileDataCache;
 
     @IntDef({SigninAccessPoint.SETTINGS, SigninAccessPoint.BOOKMARK_MANAGER,
             SigninAccessPoint.RECENT_TABS, SigninAccessPoint.SIGNIN_PROMO,
-            SigninAccessPoint.NTP_LINK})
+            SigninAccessPoint.NTP_LINK, SigninAccessPoint.AUTOFILL_DROPDOWN})
     @Retention(RetentionPolicy.SOURCE)
     public @interface AccessPoint {}
     @AccessPoint private int mAccessPoint;
 
     /**
      * A convenience method to create a AccountSigninActivity passing the access point as an
      * intent.
      * @param accessPoint - A SigninAccessPoint designating where the activity is created from.
      */
-    public static void startAccountSigninActivity(Context context, @AccessPoint int accessPoint) {
+    public static void startAccountSigninActivity(
+            Context context, @AccessPoint int accessPoint, boolean useNewTaskFlag) {
         Intent intent = new Intent(context, AccountSigninActivity.class);
         intent.putExtra(INTENT_SIGNIN_ACCESS_POINT, accessPoint);
+        if (useNewTaskFlag) {

[Ted C, 2016/07/19 20:21:48]

another thing if you find yourself doing this in the future.  Instead of passing
the boolean, you could do something like this:

if (WindowAndroid.activityFromContext(context) == null) {
    intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
}

Granted, you still need to pull the context from the window android as the app
context will never be true in that case, but it would prevent you from needing
the callers to know

[Mathieu, 2016/07/19 21:00:19]

Acknowledged.

+            intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+        }
         context.startActivity(intent);
     }
 
     /**
      * A convenience method to create a AccountSigninActivity passing the access point as an
      * intent. Checks if the sign in flow can be started before showing the activity.
      * @param accessPoint - A SigninAccessPoint designating where the activity is created from.
      * @return {@code true} if sign in has been allowed.
      */
     public static boolean startIfAllowed(Context context, @AccessPoint int accessPoint) {
         if (!SigninManager.get(context).isSignInAllowed()) {
             if (SigninManager.get(context).isSigninDisabledByPolicy()) {
                 ManagedPreferencesUtils.showManagedByAdministratorToast(context);
             }
             return false;
         }
 
-        startAccountSigninActivity(context, accessPoint);
+        startAccountSigninActivity(context, accessPoint, /* useNewTaskFlag */ false);
         return true;
     }
 
     @Override
     @SuppressFBWarnings("DM_EXIT")
     protected void onCreate(Bundle savedInstanceState) {
         // The browser process must be started here because this activity may be started from the
         // recent apps list and it relies on other activities and the native library to be loaded.
         try {
             ChromeBrowserInitializer.getInstance(this).handleSynchronousStartup();
         } catch (ProcessInitException e) {
             Log.e(TAG, "Failed to start browser process.", e);
             // Since the library failed to initialize nothing in the application
             // can work, so kill the whole application not just the activity
             System.exit(-1);
         }
 
         // We don't trust android to restore the saved state correctly, so pass null.
         super.onCreate(null);
 
         mAccessPoint = getIntent().getIntExtra(INTENT_SIGNIN_ACCESS_POINT, -1);
         assert mAccessPoint == SigninAccessPoint.BOOKMARK_MANAGER
                 || mAccessPoint == SigninAccessPoint.RECENT_TABS
                 || mAccessPoint == SigninAccessPoint.SETTINGS
                 || mAccessPoint == SigninAccessPoint.SIGNIN_PROMO
-                : "invalid access point: " + mAccessPoint;
+                || mAccessPoint
+                        == SigninAccessPoint.AUTOFILL_DROPDOWN : "invalid access point: "
+                                + mAccessPoint;
 
         mView = (AccountSigninView) LayoutInflater.from(this).inflate(
                 R.layout.account_signin_view, null);
         mView.init(getProfileDataCache());
         mView.setListener(this);
         mView.setDelegate(this);
 
         if (getAccessPoint() == SigninAccessPoint.BOOKMARK_MANAGER
                 || getAccessPoint() == SigninAccessPoint.RECENT_TABS) {
             mView.configureForRecentTabsOrBookmarksPage();
@@ skipping 55 matching lines @@
             @Override
             public void onSignInAborted() {}
         });
     }
 
     @Override
     public void onFailedToSetForcedAccount(String forcedAccountName) {}
 
     private void recordSigninStartedUserAction() {
         switch (getAccessPoint()) {
+            case SigninAccessPoint.AUTOFILL_DROPDOWN:
+                RecordUserAction.record("Signin_Signin_FromAutofillDropdown");
+                break;
             case SigninAccessPoint.BOOKMARK_MANAGER:
                 RecordUserAction.record("Signin_Signin_FromBookmarkManager");
                 break;
             case SigninAccessPoint.RECENT_TABS:
                 RecordUserAction.record("Signin_Signin_FromRecentTabs");
                 break;
             case SigninAccessPoint.SETTINGS:
                 RecordUserAction.record("Signin_Signin_FromSettings");
                 break;
             case SigninAccessPoint.SIGNIN_PROMO:
                 RecordUserAction.record("Signin_Signin_FromSigninPromo");
                 break;
             default:
                 assert false : "Invalid access point.";
         }
     }
 }