[Autofill] Add support for signin promo on Android

chrome/browser/ui/autofill/chrome_autofill_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/chrome_autofill_client.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "build/build_config.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/autofill/risk_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 #include "chrome/browser/ui/autofill/create_card_unmask_prompt_view.h"
 #include "chrome/browser/ui/autofill/credit_card_scanner_controller.h"
 #include "chrome/browser/ui/autofill/save_card_bubble_controller_impl.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ skipping 22 matching lines @@
 
 #if BUILDFLAG(ANDROID_JAVA_UI)
 #include "chrome/browser/android/chrome_application.h"
 #include "chrome/browser/ui/android/autofill/autofill_logger_android.h"
 #else
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
 #include "components/zoom/zoom_controller.h"
 #endif
 
 #if defined(OS_ANDROID)
+#include "base/android/context_utils.h"
+#include "chrome/browser/android/signin/signin_promo_util.h"
 #include "components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h"
 #include "components/autofill/core/browser/autofill_save_card_infobar_mobile.h"
 #include "components/infobars/core/infobar.h"
 #endif
 
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(autofill::ChromeAutofillClient);
 
 namespace autofill {
 
 ChromeAutofillClient::ChromeAutofillClient(content::WebContents* web_contents)
@@ skipping 261 matching lines @@
 
   ssl_status = navigation_entry->GetSSL();
   // Note: If changing the implementation below, also change
   // AwAutofillClient::IsContextSecure. See crbug.com/505388
   return ssl_status.security_style == content::SECURITY_STYLE_AUTHENTICATED &&
          !(ssl_status.content_status &
            content::SSLStatus::RAN_INSECURE_CONTENT);
 }
 
 bool ChromeAutofillClient::ShouldShowSigninPromo() {
-#if defined(OS_ANDROID) || defined(OS_IOS)
-  // TODO(crbug.com/626383): Implement signin promo for Android and iOS by
-  // changing the logic of StartSigninFlow() below.
+#if defined(OS_IOS)
+  // TODO(crbug.com/626383): Implement sign-in promo for iOS by changing the
+  // logic of StartSigninFlow() below.
   return false;
+#elif defined(OS_ANDROID)
+  // On Android, we show the promo if the user is signed out and not currently
+  // signing in.
+  Profile* profile = ProfileManager::GetActiveUserProfile();
+  SigninManager* signin = SigninManagerFactory::GetForProfile(profile);
+  return !signin->AuthInProgress() && signin->IsSigninAllowed() &&

[Evan Stade, 2016/07/12 18:16:22]

this looks suspiciously similar to the implementation of ShouldShowPromo

[Mathieu, 2016/07/12 18:47:25]

Unfortunately signing_promo.h/cc is not included on Android/iOS.

https://cs.chromium.org/chromium/src/chrome/chrome_browser.gypi?rcl=0&l=1455

+         !signin->IsAuthenticated();
 #else
   return chrome::FindBrowserWithWebContents(web_contents()) &&
          signin::ShouldShowPromo(
              Profile::FromBrowserContext(web_contents()->GetBrowserContext()));
 #endif
 }
 
 void ChromeAutofillClient::StartSigninFlow() {
 // See ShouldShowSigninPromo.
-#if !defined(OS_ANDROID) && !defined(OS_IOS)
+#if defined(OS_IOS)
+  return;
+#elif defined(OS_ANDROID)
+  chrome::android::SigninPromoUtil::OpenAccountSigninActivityForPromo(
+      signin_metrics::AccessPoint::ACCESS_POINT_AUTOFILL_DROPDOWN);
+#else
   chrome::FindBrowserWithWebContents(web_contents())
       ->window()
       ->ShowAvatarBubbleFromAvatarButton(
           BrowserWindow::AVATAR_BUBBLE_MODE_SIGNIN,
           signin::ManageAccountsParams(),
           signin_metrics::AccessPoint::ACCESS_POINT_AUTOFILL_DROPDOWN);
 #endif
 }
 
 }  // namespace autofill