Revert three commits due to cpu-profiler failures

Revert three commits due to cpu-profiler failures.

Revert "Move SimulatorHelper into V8 out of profiler clients."

This reverts commit b837241150409db71b07bd989872a494a31ca673.

Revert "Make use of v8::TickSample instead of v8::internal::TickSample in logger."

This reverts commit c3a16f0a9f0976411ee25df627534be5f6955c32.

Revert "Clean up SimulatorHelper code."

This reverts commit 8ee236e144c95f719eebe0bf08c85d290f801abe.

BUG=v8:5193
TBR=alph@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/4af2bb9e38f3c9d6679fd5203512caeec1932f68
Cr-Commit-Position: refs/heads/master@{#37626}

[Michael Achenbach, 2016-07-11 07:37:07]

Description was changed from

==========
Revert "Move SimulatorHelper into V8 out of profiler clients."

This reverts commit b837241150409db71b07bd989872a494a31ca673.

Revert "Make use of v8::TickSample instead of v8::internal::TickSample in
logger."

This reverts commit c3a16f0a9f0976411ee25df627534be5f6955c32.

Revert "Clean up SimulatorHelper code."

This reverts commit 8ee236e144c95f719eebe0bf08c85d290f801abe.

BUG=
==========

to

==========
Revert three commits for to cpu-profiler failures.

Revert "Move SimulatorHelper into V8 out of profiler clients."

This reverts commit b837241150409db71b07bd989872a494a31ca673.

Revert "Make use of v8::TickSample instead of v8::internal::TickSample in
logger."

This reverts commit c3a16f0a9f0976411ee25df627534be5f6955c32.

Revert "Clean up SimulatorHelper code."

This reverts commit 8ee236e144c95f719eebe0bf08c85d290f801abe.

BUG=v8:5193
TBR=alph@chromium.org, yangguo@chromium.org
==========

[Michael Achenbach, 2016-07-11 07:37:07]

machenbach@chromium.org changed reviewers:
+ alph@chromium.org, yangguo@chromium.org

[Michael Achenbach, 2016-07-11 07:37:35]

Description was changed from

==========
Revert three commits for to cpu-profiler failures.

Revert "Move SimulatorHelper into V8 out of profiler clients."

This reverts commit b837241150409db71b07bd989872a494a31ca673.

Revert "Make use of v8::TickSample instead of v8::internal::TickSample in
logger."

This reverts commit c3a16f0a9f0976411ee25df627534be5f6955c32.

Revert "Clean up SimulatorHelper code."

This reverts commit 8ee236e144c95f719eebe0bf08c85d290f801abe.

BUG=v8:5193
TBR=alph@chromium.org, yangguo@chromium.org
==========

to

==========
Revert three commits due to cpu-profiler failures.

Revert "Move SimulatorHelper into V8 out of profiler clients."

This reverts commit b837241150409db71b07bd989872a494a31ca673.

Revert "Make use of v8::TickSample instead of v8::internal::TickSample in
logger."

This reverts commit c3a16f0a9f0976411ee25df627534be5f6955c32.

Revert "Clean up SimulatorHelper code."

This reverts commit 8ee236e144c95f719eebe0bf08c85d290f801abe.

BUG=v8:5193
TBR=alph@chromium.org, yangguo@chromium.org
==========

[Michael Achenbach, 2016-07-11 07:37:50]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-11 07:38:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-07-11 07:39:07]

TBR: This led to failures on arm64 sim release:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

And flakes on arm64 sim debug:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

Both the failures and the flakes persisted afterwards.

[Yang, 2016-07-11 07:41:17]

On 2016/07/11 07:39:07, Michael Achenbach wrote:
> TBR: This led to failures on arm64 sim release:
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
> 
> And flakes on arm64 sim debug:
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
> 
> Both the failures and the flakes persisted afterwards.

lgtm

[Michael Achenbach, 2016-07-11 07:43:34]

On 2016/07/11 07:41:17, Yang wrote:
> On 2016/07/11 07:39:07, Michael Achenbach wrote:
> > TBR: This led to failures on arm64 sim release:
> >
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
> > 
> > And flakes on arm64 sim debug:
> >
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
> > 
> > Both the failures and the flakes persisted afterwards.
> 
> lgtm

FYI: Our release trybots use dcheck_always_on which defines "debug" in v8. Like
that, pure-release-only bugs can sneak through CQ...

[commit-bot: I haz the power, 2016-07-11 08:03:11]

Description was changed from

==========
Revert three commits due to cpu-profiler failures.

Revert "Move SimulatorHelper into V8 out of profiler clients."

This reverts commit b837241150409db71b07bd989872a494a31ca673.

Revert "Make use of v8::TickSample instead of v8::internal::TickSample in
logger."

This reverts commit c3a16f0a9f0976411ee25df627534be5f6955c32.

Revert "Clean up SimulatorHelper code."

This reverts commit 8ee236e144c95f719eebe0bf08c85d290f801abe.

BUG=v8:5193
TBR=alph@chromium.org, yangguo@chromium.org
==========

to

==========
Revert three commits due to cpu-profiler failures.

Revert "Move SimulatorHelper into V8 out of profiler clients."

This reverts commit b837241150409db71b07bd989872a494a31ca673.

Revert "Make use of v8::TickSample instead of v8::internal::TickSample in
logger."

This reverts commit c3a16f0a9f0976411ee25df627534be5f6955c32.

Revert "Clean up SimulatorHelper code."

This reverts commit 8ee236e144c95f719eebe0bf08c85d290f801abe.

BUG=v8:5193
TBR=alph@chromium.org, yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-07-11 08:03:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-11 08:03:39]

Description was changed from

==========
Revert three commits due to cpu-profiler failures.

Revert "Move SimulatorHelper into V8 out of profiler clients."

This reverts commit b837241150409db71b07bd989872a494a31ca673.

Revert "Make use of v8::TickSample instead of v8::internal::TickSample in
logger."

This reverts commit c3a16f0a9f0976411ee25df627534be5f6955c32.

Revert "Clean up SimulatorHelper code."

This reverts commit 8ee236e144c95f719eebe0bf08c85d290f801abe.

BUG=v8:5193
TBR=alph@chromium.org, yangguo@chromium.org
==========

to

==========
Revert three commits due to cpu-profiler failures.

Revert "Move SimulatorHelper into V8 out of profiler clients."

This reverts commit b837241150409db71b07bd989872a494a31ca673.

Revert "Make use of v8::TickSample instead of v8::internal::TickSample in
logger."

This reverts commit c3a16f0a9f0976411ee25df627534be5f6955c32.

Revert "Clean up SimulatorHelper code."

This reverts commit 8ee236e144c95f719eebe0bf08c85d290f801abe.

BUG=v8:5193
TBR=alph@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/4af2bb9e38f3c9d6679fd5203512caeec1932f68
Cr-Commit-Position: refs/heads/master@{#37626}
==========

[commit-bot: I haz the power, 2016-07-11 08:03:40]

Patchset 1 (id:??) landed as
https://crrev.com/4af2bb9e38f3c9d6679fd5203512caeec1932f68
Cr-Commit-Position: refs/heads/master@{#37626}