Split time-multiple-fields-stepup-stepdown-from-renderer.html into two.

Split time-multiple-fields-stepup-stepdown-from-renderer.html into two.

In this test, MultipleFieldsTemporalInputTypeView::updateView() is called on every
attribute update (1,000+ times), and it's not trivial to optimize updateView().

This CL splits the test into two, and skip unnecessary attribute update.

BUG=24182
Committed: https://crrev.com/9ebde8142cce650aebf8e4f2c8092a039bc16ca0
Cr-Commit-Position: refs/heads/master@{#404764}

[tkent, 2016-07-11 08:27:16]

Description was changed from

==========
Split time-multiple-fields-stepup-stepdown-from-renderer.html into two.

BUG=
==========

to

==========
Split time-multiple-fields-stepup-stepdown-from-renderer.html into two.

BUG=24182
==========

[tkent, 2016-07-11 08:28:03]

Patchset #1 (id:1) has been deleted

[tkent, 2016-07-11 08:30:25]

Description was changed from

==========
Split time-multiple-fields-stepup-stepdown-from-renderer.html into two.

BUG=24182
==========

to

==========
Split time-multiple-fields-stepup-stepdown-from-renderer.html into two.

In this test, MultipleFieldsTemporalInputTypeView::updateView() is called on
every
attribute update (1,000+ times), and it's not trivial to optimize updateView().

This CL split the test into two, and skip unnecessary attribute update.

BUG=24182
==========

[tkent, 2016-07-11 08:31:35]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-07-11 08:31:36]

yosin@, would you review this please?

I don't convert the test to testharness.js in this CL because it makes code
review harder.

[tkent, 2016-07-11 08:32:11]

Description was changed from

==========
Split time-multiple-fields-stepup-stepdown-from-renderer.html into two.

In this test, MultipleFieldsTemporalInputTypeView::updateView() is called on
every
attribute update (1,000+ times), and it's not trivial to optimize updateView().

This CL split the test into two, and skip unnecessary attribute update.

BUG=24182
==========

to

==========
Split time-multiple-fields-stepup-stepdown-from-renderer.html into two.

In this test, MultipleFieldsTemporalInputTypeView::updateView() is called on
every
attribute update (1,000+ times), and it's not trivial to optimize updateView().

This CL splits the test into two, and skip unnecessary attribute update.

BUG=24182
==========

[yosin_UTC9, 2016-07-12 01:12:09]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-07-12 01:12:09]

lgtm

https://codereview.chromium.org/2138633003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-hour.html
(right):

https://codereview.chromium.org/2138633003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-hour.html:29:
if (value) {
Just attempt to shuffling lines.

# BAD: extra hasAttribute call
29 if (input.hasAttribute(name)) {
30  if (value == input.getAttribute(name))
31    return;
32  input.setAttribute(name, value);
33  return;
34 }
35 if (!value)
36   return;
37 input.setAttribute(name, value);


# BAD +1 line
29 if (value) {
30  if (input.getAttribute(name) == value)
31    return;
32  input.setAttribute(name, value);
33  return;
34 }
35 if (!input.hasAttribute(name))
36  return;
37 input.removeAttribute(name);

[commit-bot: I haz the power, 2016-07-12 01:13:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 01:21:44]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-07-12 01:22:14]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-12 01:24:57]

Description was changed from

==========
Split time-multiple-fields-stepup-stepdown-from-renderer.html into two.

In this test, MultipleFieldsTemporalInputTypeView::updateView() is called on
every
attribute update (1,000+ times), and it's not trivial to optimize updateView().

This CL splits the test into two, and skip unnecessary attribute update.

BUG=24182
==========

to

==========
Split time-multiple-fields-stepup-stepdown-from-renderer.html into two.

In this test, MultipleFieldsTemporalInputTypeView::updateView() is called on
every
attribute update (1,000+ times), and it's not trivial to optimize updateView().

This CL splits the test into two, and skip unnecessary attribute update.

BUG=24182

Committed: https://crrev.com/9ebde8142cce650aebf8e4f2c8092a039bc16ca0
Cr-Commit-Position: refs/heads/master@{#404764}
==========

[commit-bot: I haz the power, 2016-07-12 01:24:58]

Patchset 1 (id:??) landed as
https://crrev.com/9ebde8142cce650aebf8e4f2c8092a039bc16ca0
Cr-Commit-Position: refs/heads/master@{#404764}