[turbofan] Introduce CheckedInt32Div and CheckedInt32Mod operators.

[turbofan] Introduce CheckedInt32Div and CheckedInt32Mod operators.

Consume Smi/Signed32 feedback for division and modulus and introduce
appropriate checked operators. This is especially important for modulus
where the Float64Mod operator is significantly slower than Int32Mod on
most platforms. For division it's mostly important to propagate
integerness, i.e. to avoid follow-up conversions between float and
int32.

Drive-by-fix: Use Int32Mod for the ModulusStub (and the bytecode handler)
when the inputs are both Smi.

R=jarin@chromium.org

Committed: https://crrev.com/03bde2660a81d532fbe081870cdbb26c8ecc04e9
Cr-Commit-Position: refs/heads/master@{#37621}

[Benedikt Meurer, 2016-07-11 03:59:23]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 03:59:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-07-11 04:06:41]

Hey Jaro,

Here's another Kraken helper.
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2016-07-11 04:24:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 04:24:20]

Dry run: This issue passed the CQ dry run.

[Jarin, 2016-07-11 04:47:20]

This looks awesome, thanks!

lgtm.

https://codereview.chromium.org/2138633002/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2138633002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:354: // Check if {a} is positive (or zero).
We call this non-negative.

https://codereview.chromium.org/2138633002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:367: Bind(&if_aisnotpositive);
notpositive -> negative

https://codereview.chromium.org/2138633002/diff/1/src/compiler/effect-control...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2138633002/diff/1/src/compiler/effect-control...
src/compiler/effect-control-linearizer.cc:971: // to return -0.
-0 --> -kMinInt?

[Benedikt Meurer, 2016-07-11 05:03:23]

https://codereview.chromium.org/2138633002/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2138633002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:354: // Check if {a} is positive (or zero).
On 2016/07/11 04:47:20, Jarin wrote:
> We call this non-negative.

Done.

https://codereview.chromium.org/2138633002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:367: Bind(&if_aisnotpositive);
On 2016/07/11 04:47:20, Jarin wrote:
> notpositive -> negative

Done.

https://codereview.chromium.org/2138633002/diff/1/src/compiler/effect-control...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2138633002/diff/1/src/compiler/effect-control...
src/compiler/effect-control-linearizer.cc:971: // to return -0.
On 2016/07/11 04:47:20, Jarin wrote:
> -0 --> -kMinInt?

Done.

[Benedikt Meurer, 2016-07-11 05:03:26]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-07-11 05:03:27]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2138633002/#ps20001
(title: "Comments")

[commit-bot: I haz the power, 2016-07-11 05:03:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 05:27:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-11 05:28:06]

Description was changed from

==========
[turbofan] Introduce CheckedInt32Div and CheckedInt32Mod operators.

Consume Smi/Signed32 feedback for division and modulus and introduce
appropriate checked operators. This is especially important for modulus
where the Float64Mod operator is significantly slower than Int32Mod on
most platforms. For division it's mostly important to propagate
integerness, i.e. to avoid follow-up conversions between float and
int32.

Drive-by-fix: Use Int32Mod for the ModulusStub (and the bytecode handler)
when the inputs are both Smi.

R=jarin@chromium.org
==========

to

==========
[turbofan] Introduce CheckedInt32Div and CheckedInt32Mod operators.

Consume Smi/Signed32 feedback for division and modulus and introduce
appropriate checked operators. This is especially important for modulus
where the Float64Mod operator is significantly slower than Int32Mod on
most platforms. For division it's mostly important to propagate
integerness, i.e. to avoid follow-up conversions between float and
int32.

Drive-by-fix: Use Int32Mod for the ModulusStub (and the bytecode handler)
when the inputs are both Smi.

R=jarin@chromium.org

Committed: https://crrev.com/03bde2660a81d532fbe081870cdbb26c8ecc04e9
Cr-Commit-Position: refs/heads/master@{#37621}
==========

[commit-bot: I haz the power, 2016-07-11 05:28:07]

Patchset 2 (id:??) landed as
https://crrev.com/03bde2660a81d532fbe081870cdbb26c8ecc04e9
Cr-Commit-Position: refs/heads/master@{#37621}