Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2138623002: Update generated *_pb2.py event_mon files (Closed)

Created:
4 years, 5 months ago by tikuta
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Update generated *_pb2.py event_mon files Summary of changes: * loaded_size_bytes field was added to RequestStats message in goma_stats.proto that stores the size of compiler info cache * BuildCategory enum and category field was added to BuildEvent message to store category build property * FAILED_PRESUBMIT_BOT_INFRA, FAILED_TO_TRIGGER_JOBS and UNSUPPORTED_CQ_FEATURE values were added to FailType enum in CQEvent message * config_revision field was added to CQEvent message BUG=562109, 579589 Committed: https://chromium.googlesource.com/infra/infra/+/83dfe87b00f8eadc467ead5766e256cfc5548db0

Patch Set 1 #

Patch Set 2 : Add loaded_size_bytes in goma_stats.proto and regenerate *_pb2.py #

Patch Set 3 : rebase chrome_infra_log_pb2.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -94 lines) Patch
M infra_libs/event_mon/protos/chrome_infra_log_pb2.py View 1 2 25 chunks +57 lines, -50 lines 0 comments Download
M infra_libs/event_mon/protos/goma_stats_pb2.py View 25 chunks +55 lines, -44 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
tikuta
4 years, 5 months ago (2016-07-11 07:56:22 UTC) #8
Sergiy Byelozyorov
lgtm provided changes in proto are already in production, check latest deployed CL here: https://cl-status.corp.google.com/#/summary/clearcut_server ...
4 years, 5 months ago (2016-07-11 08:19:04 UTC) #9
Sergiy Byelozyorov
On 2016/07/11 08:19:04, Sergiy Byelozyorov wrote: > lgtm provided changes in proto are already in ...
4 years, 5 months ago (2016-07-11 10:07:25 UTC) #10
Sergiy Byelozyorov
On 2016/07/11 10:07:25, Sergiy Byelozyorov wrote: > On 2016/07/11 08:19:04, Sergiy Byelozyorov wrote: > > ...
4 years, 5 months ago (2016-07-11 10:09:10 UTC) #11
Sergiy Byelozyorov
On 2016/07/11 10:09:10, Sergiy Byelozyorov wrote: > On 2016/07/11 10:07:25, Sergiy Byelozyorov wrote: > > ...
4 years, 5 months ago (2016-07-11 10:18:26 UTC) #14
tandrii(chromium)
LGTM (and thanks for updating descr, sergiyb@)
4 years, 5 months ago (2016-07-11 12:50:25 UTC) #16
Yoshisato Yanagisawa
lgtm
4 years, 5 months ago (2016-07-12 03:43:15 UTC) #17
ukai
lgtm
4 years, 5 months ago (2016-07-12 07:41:18 UTC) #18
shinyak
lgtm
4 years, 5 months ago (2016-07-12 08:08:36 UTC) #19
tikuta
Thank you for review. Thank you sergiyb@ updating description. I confirm that my change landed ...
4 years, 5 months ago (2016-07-13 03:55:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138623002/40001
4 years, 5 months ago (2016-07-13 04:15:41 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:29:58 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/83dfe87b00f8eadc467ead5766e25...

Powered by Google App Engine
This is Rietveld 408576698