third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp - Issue 2138613002: Set the font family for the "system-ui" generic font family on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp

Issue 2138613002: Set the font family for the "system-ui" generic font family on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: jochen review nit (add braces) Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/android/FontCacheAndroid.cpp ('k') | third_party/WebKit/Source/web/linux/WebFontRendering.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp b/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp

index 7bdc2a3a9eab4514e30d059c5600fe7b58d855e0..4b51489187fbea7431d364d8964d8bc4c04ec452 100644

--- a/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp

+++ b/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp

@@ -54,8 +54,8 @@ const AtomicString& FontCache::systemFontFamily() {

}

// static

-void FontCache::setSystemFontFamily(const char* familyName) {

- DCHECK(familyName && *familyName);

+void FontCache::setSystemFontFamily(const AtomicString& familyName) {

+ DCHECK(!familyName.isEmpty());

mutableSystemFontFamily() = familyName;

}