third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/layout-fonts/generic-system-ui-expected.txt - Issue 2138613002: Set the font family for the "system-ui" generic font family on Linux

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/layout-fonts/generic-system-ui-expected.txt

Issue 2138613002: Set the font family for the "system-ui" generic font family on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed char* to WebString Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 This text should use the system font.	1 This text should use the system font.

2 #system-ui:	2 #system-ui:

3 "Times New Roman" : 37	3 "Arial" : 37
	drott 2016/10/20 15:18:40 Could you explain why this ends up being Arial? Is Could you explain why this ends up being Arial? Is this because setSystemFontFamily is not set for layout tests, and then we do the empty SkTypeface fallback (which I thought should give us a font that fontconfig mapped to "Sans", or if it doesn't find Sans, then Arial as secondary fallback, see FontCache::getLastResortFallbackFont). Or does this have a different reason, like does this come from gfx::Font()? Could you add such an explanation to the CL description?
4	4

5 This text should use the system font.	5 This text should use the system font.

6 #system-ui-20pt:	6 #system-ui-20pt:

7 "Times New Roman" : 37	7 "Arial" : 37

8	8

9	9

OLD	NEW

« content/renderer/render_view_linux.cc ('K') | « content/renderer/render_view_linux.cc ('k') | third_party/WebKit/Source/platform/fonts/FontCache.h » ('j') | no next file with comments »