Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2138603002: Keep resolution results in more cases. Invalidate only errors. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Keep resolution results in more cases. Invalidate only errors. 1. Subclassing does not change resolution, so we need to invalidate only HINTS (for invalid @override) and VERIFY_ERRORS (for unimplemented or type-conflicting (from multiple supers) members). 2. OTOH instantiation of a class with a (members) delta does not change nor resolution, not the set of errors. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0ba58ef1b69d31e58570b24d5ef6d6d20a280a5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -73 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 5 chunks +58 lines, -16 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 11 chunks +131 lines, -57 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-10 17:33:07 UTC) #1
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-11 13:51:05 UTC) #2
scheglov
4 years, 5 months ago (2016-07-11 16:27:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ba58ef1b69d31e58570b24d5ef6d6d20a280a5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698