Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2138593002: Remove CHECKs used for debugging bug 425785. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CHECKs used for debugging bug 425785. BUG=425785 Committed: https://crrev.com/1e9dc390f0cdd1de753f16eb706c3cc29c27f0b3 Cr-Commit-Position: refs/heads/master@{#404915}

Patch Set 1 #

Patch Set 2 : typos #

Total comments: 2

Patch Set 3 : Revert a DCHECK for bug 627031 #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service.cc View 1 2 4 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
Lei Zhang
4 years, 5 months ago (2016-07-11 04:30:04 UTC) #2
Bernhard Bauer
LGTM, thanks!
4 years, 5 months ago (2016-07-11 09:09:15 UTC) #3
Bernhard Bauer
https://codereview.chromium.org/2138593002/diff/20001/chrome/browser/supervised_user/supervised_user_settings_service.cc File chrome/browser/supervised_user/supervised_user_settings_service.cc (left): https://codereview.chromium.org/2138593002/diff/20001/chrome/browser/supervised_user/supervised_user_settings_service.cc#oldcode81 chrome/browser/supervised_user/supervised_user_settings_service.cc:81: CHECK(store_->IsInitializationComplete()); Actually, this CHECK still seems to trigger (even ...
4 years, 5 months ago (2016-07-11 09:26:36 UTC) #4
Lei Zhang
https://codereview.chromium.org/2138593002/diff/20001/chrome/browser/supervised_user/supervised_user_settings_service.cc File chrome/browser/supervised_user/supervised_user_settings_service.cc (left): https://codereview.chromium.org/2138593002/diff/20001/chrome/browser/supervised_user/supervised_user_settings_service.cc#oldcode81 chrome/browser/supervised_user/supervised_user_settings_service.cc:81: CHECK(store_->IsInitializationComplete()); On 2016/07/11 09:26:36, Bernhard Bauer wrote: > Actually, ...
4 years, 5 months ago (2016-07-11 22:25:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138593002/60001
4 years, 5 months ago (2016-07-11 22:26:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242034)
4 years, 5 months ago (2016-07-12 00:05:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138593002/60001
4 years, 5 months ago (2016-07-12 00:10:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242119)
4 years, 5 months ago (2016-07-12 01:28:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138593002/60001
4 years, 5 months ago (2016-07-12 01:42:36 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190689)
4 years, 5 months ago (2016-07-12 04:33:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138593002/60001
4 years, 5 months ago (2016-07-12 20:50:56 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-13 02:30:43 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 02:31:56 UTC) #23
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/1e9dc390f0cdd1de753f16eb706c3cc29c27f0b3
Cr-Commit-Position: refs/heads/master@{#404915}

Powered by Google App Engine
This is Rietveld 408576698