Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2138583002: Use output_all_resource_defines=false in most grd files. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
CC:
chromium-reviews, sadrul, chromoting-reviews_chromium.org, achuith+watch_chromium.org, nyquist+watch-blimp_chromium.org, rginda+watch_chromium.org, scheib+watch_chromium.org, kmarshall+watch-blimp_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, je_julie, shaktisahu+watch-blimp_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, Matt Giuca, aboxhall+watch_chromium.org, lcwu+watch_chromium.org, dzhioev+watch_chromium.org, jam, dglazkov+blink, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, halliwell+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, kalyank, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, lethalantidote+watch-blimp_chromium.org, tapted, Peter Beverloo, caseq+blink_chromium.org, lushnikov+blink_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, alokp+watch_chromium.org, sergeyv+blink_chromium.org, khushalsagar+watch-blimp_chromium.org, sdefresne+watch_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, wfh+watch_chromium.org, nektar+watch_chromium.org, blink-reviews-api_chromium.org, pfeldman+blink_chromium.org, mtomasz+watch_chromium.org, pfeldman, dtseng+watch_chromium.org, tfarina, ortuno+watch_chromium.org, apavlov+blink_chromium.org, dtrainor+watch-blimp_chromium.org, jshin+watch_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use output_all_resource_defines=false in most grd files. - Mark code in ash/ that should be platform-specific - Fix lint errors in ash/display/display_util.cc BUG=333201 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation TBR=dtrainor@chromium.org,halliwell@chromium.org,jochen@chromium.org,juliatuttle@chromium.org,rockot@chromium.org,sdefresne@chromium.org,sky@chromium.org,skyostil@chromium.org,wez@chromium.org Committed: https://crrev.com/6db17dc98dcf90da3e28f7d0b39cfcb0a326a294 Cr-Commit-Position: refs/heads/master@{#404775}

Patch Set 1 #

Patch Set 2 : revert ui_resources.grd for now #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -80 lines) Patch
M android_webview/java/strings/android_webview_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/ui/aw_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/ui/aw_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/tray_image_item.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M ash/common/system/tray/tray_notification_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/display/display_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/display/display_util.cc View 6 chunks +15 lines, -14 lines 2 comments Download
M ash/mus/resources/ash_mus_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/android/java/strings/android_blimp_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/resources/chromecast_settings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/resources/shell_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/chrome_apps/chrome_apps_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/components_chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/components_google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/components_locale_settings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/resources/policy_templates.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/resources/components_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/resources/components_scaled_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/app/resources/content_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/app/strings/content_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/generate_trace_viewer_grd.py View 1 chunk +2 lines, -1 line 0 comments Download
M content/content_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/strings/android_content_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/resources/extensions_browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/app_shell_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M headless/lib/resources/headless_lib_resources.grd View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/app/resources/ios_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/app/strings/ios_chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/app/strings/ios_google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/app/theme/ios_theme_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/share_extension/strings/ios_share_extension_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/today_extension/strings/ios_today_extension_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/ios_web_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/test/test_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M remoting/resources/remoting_strings.grd View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/scripts/generate_devtools_grd.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink_image_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/blink_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/extensions/strings/accessibility_extensions_strings.grd View 1 chunk +2 lines, -1 line 0 comments Download
M ui/android/java/strings/android_ui_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/resources/app_list_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/resources/ui_chromeos_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/ui_chromeos_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/login/login_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/ui_unscaled_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/app_locale_settings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (15 generated)
Lei Zhang
PTAL at ash/, I'll TBR the rest.
4 years, 5 months ago (2016-07-11 17:44:21 UTC) #4
Daniel Erat
https://codereview.chromium.org/2138583002/diff/20001/ash/display/display_util.cc File ash/display/display_util.cc (right): https://codereview.chromium.org/2138583002/diff/20001/ash/display/display_util.cc#newcode129 ash/display/display_util.cc:129: DisplayMode FindNextMode(const std::vector<DisplayMode>& modes, i don't understand why these ...
4 years, 5 months ago (2016-07-11 17:50:20 UTC) #5
Lei Zhang
https://codereview.chromium.org/2138583002/diff/20001/ash/display/display_util.cc File ash/display/display_util.cc (right): https://codereview.chromium.org/2138583002/diff/20001/ash/display/display_util.cc#newcode129 ash/display/display_util.cc:129: DisplayMode FindNextMode(const std::vector<DisplayMode>& modes, On 2016/07/11 17:50:20, Daniel Erat ...
4 years, 5 months ago (2016-07-11 17:53:10 UTC) #7
Daniel Erat
thanks, lgtm for ash
4 years, 5 months ago (2016-07-11 18:01:09 UTC) #8
Lei Zhang
TBRing the rest: jochen: components, content, third_party/WebKit sdefresne: ios sky: ui rockot: device, extensions dtrainor: ...
4 years, 5 months ago (2016-07-11 20:34:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138583002/20001
4 years, 5 months ago (2016-07-11 20:35:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/215355)
4 years, 5 months ago (2016-07-11 20:45:24 UTC) #14
Lei Zhang
... and actually add TBR= to the commit message.
4 years, 5 months ago (2016-07-11 21:15:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138583002/20001
4 years, 5 months ago (2016-07-11 21:17:07 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253303)
4 years, 5 months ago (2016-07-11 23:10:58 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138583002/20001
4 years, 5 months ago (2016-07-11 23:15:05 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253469)
4 years, 5 months ago (2016-07-12 01:41:59 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138583002/20001
4 years, 5 months ago (2016-07-12 02:06:32 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-12 03:38:03 UTC) #28
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 03:38:39 UTC) #29
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6db17dc98dcf90da3e28f7d0b39cfcb0a326a294 Cr-Commit-Position: refs/heads/master@{#404775}
4 years, 5 months ago (2016-07-12 03:39:40 UTC) #31
sky
ui LGTM
4 years, 5 months ago (2016-07-18 15:25:10 UTC) #32
Julia Tuttle
4 years, 5 months ago (2016-07-18 17:27:49 UTC) #33
Message was sent while issue was closed. 
net lgtm, if that's what you wanted me for

Powered by Google App Engine
This is Rietveld 408576698