Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 213853002: Always list EthernetEAP as a Favorite for debugging (Closed)

Created:
6 years, 9 months ago by stevenjb
Modified:
6 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Always list EthernetEAP as a Favorite for debugging Because EthernetEAP is never a visible service, we do not observe it. When it is first created, no properties (including Profile) are set, so it does not appear in the 'Favorite' list and as a result never gets updated. This currently only affects debugging. As a workaround, we always treat EthernetEAP networks as a Favorite, eveb if Profile is empty. Original CL: https://codereview.chromium.org/210433002/ This patch removes a failing test for some unused code (removed both). BUG=355117 TBR=pneubeck@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260217

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -42 lines) Patch
M chromeos/network/favorite_state.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chromeos/network/favorite_state.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chromeos/network/managed_state.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/network/managed_state.cc View 2 chunks +14 lines, -1 line 0 comments Download
M chromeos/network/network_state_handler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 6 chunks +6 lines, -17 lines 0 comments Download
M chromeos/network/network_state_handler_unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chromeos/network/shill_property_handler.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 9 months ago (2014-03-26 23:16:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/213853002/1
6 years, 9 months ago (2014-03-26 23:16:22 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 05:53:58 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=289080
6 years, 9 months ago (2014-03-27 05:53:58 UTC) #4
stevenjb
6 years, 9 months ago (2014-03-28 18:44:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r260217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698