components/arc/test/fake_notifications_instance.h - Issue 2138513002: arc: Use the new InstanceHolder for unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/test/fake_notifications_instance.h

Issue 2138513002: arc: Use the new InstanceHolder for unittests (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@bridge_refactor_first

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/arc/test/fake_app_instance.cc ('k') | components/arc/test/fake_notifications_instance.cc » ('j') | ui/arc/notification/arc_notification_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/arc/test/fake_notifications_instance.h

diff --git a/components/arc/test/fake_notifications_instance.h b/components/arc/test/fake_notifications_instance.h

index 88f68c06d3e38f8e67fe299412057928034b6f21..3b9eb15353c0cbd417e1d3be07c39256938a4a11 100644

--- a/components/arc/test/fake_notifications_instance.h

+++ b/components/arc/test/fake_notifications_instance.h

@@ -12,8 +12,7 @@ namespace arc {

class FakeNotificationsInstance : public mojom::NotificationsInstance {

public:

- FakeNotificationsInstance(

- mojo::InterfaceRequest<mojom::NotificationsInstance> request);

+ FakeNotificationsInstance();

~FakeNotificationsInstance() override;

void Init(mojom::NotificationsHostPtr host_ptr) override;

@@ -25,13 +24,9 @@ class FakeNotificationsInstance : public mojom::NotificationsInstance {

const std::vector<std::pair<mojo::String, mojom::ArcNotificationEvent>>&

events() const;

- void WaitForIncomingMethodCall();

private:

std::vector<std::pair<mojo::String, mojom::ArcNotificationEvent>> events_;

- mojo::Binding<mojom::NotificationsInstance> binding_;

DISALLOW_COPY_AND_ASSIGN(FakeNotificationsInstance);

};