Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 2138503002: Creating contents state byte array before opening stream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: renamed variables, added javadoc, updated AUTHORS Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
index 926cedf41ccdefbf4b2ba29d5a3e02ffe68fb24f..b4d4733d4984cb3f21ae063a447b34123ab02a84 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
@@ -24,7 +24,6 @@ import org.chromium.base.ActivityState;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.ApplicationStatus;
import org.chromium.base.Log;
-import org.chromium.base.StreamUtil;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.blink_public.platform.WebDisplayMode;
@@ -46,9 +45,6 @@ import org.chromium.net.NetworkChangeNotifier;
import org.chromium.ui.base.PageTransition;
import java.io.File;
-import java.io.FileNotFoundException;
-import java.io.FileOutputStream;
-import java.io.IOException;
import java.util.concurrent.TimeUnit;
/**
@@ -176,22 +172,15 @@ public class WebappActivity extends FullScreenActivity {
String tabFileName = TabState.getTabStateFilename(getActivityTab().getId(), false);
File tabFile = new File(activityDirectory, tabFileName);
- FileOutputStream foutput = null;
// Temporarily allowing disk access while fixing. TODO: http://crbug.com/525781
StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
StrictMode.allowThreadDiskWrites();
try {
long time = SystemClock.elapsedRealtime();
- foutput = new FileOutputStream(tabFile);
- TabState.saveState(foutput, getActivityTab().getState(), false);
+ TabState.saveState(tabFile, getActivityTab().getState(), false);
RecordHistogram.recordTimesHistogram("Android.StrictMode.WebappSaveState",
SystemClock.elapsedRealtime() - time, TimeUnit.MILLISECONDS);
- } catch (FileNotFoundException exception) {
- Log.e(TAG, "Failed to save out tab state.", exception);
- } catch (IOException exception) {
- Log.e(TAG, "Failed to save out tab state.", exception);
} finally {
- StreamUtil.closeQuietly(foutput);
StrictMode.setThreadPolicy(oldPolicy);
}
}

Powered by Google App Engine
This is Rietveld 408576698