Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java

Issue 2138503002: Creating contents state byte array before opening stream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: renamed variables, added javadoc, updated AUTHORS Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
index 9a8bf23a227bcf67c6d964e0bd6b9e28b311c216..7172413886bf0451197cc0b28b5b27e79c824a5f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
@@ -341,20 +341,14 @@ public class TabPersistentStore extends TabPersister {
for (Tab tab : mTabsToSave) {
int id = tab.getId();
boolean incognito = tab.isIncognito();
- FileOutputStream stream = null;
try {
TabState state = tab.getState();
if (state != null) {
- stream = openTabStateOutputStream(id, incognito);
- TabState.saveState(stream, state, incognito);
+ TabState.saveState(getTabStateFile(id, incognito), state, incognito);
}
- } catch (IOException e) {
- Log.w(TAG, "Error while saving tabs state; will attempt to continue...", e);
} catch (OutOfMemoryError e) {
Log.w(TAG, "Out of memory error while attempting to save tab state. Erasing.");
deleteTabState(id, incognito);
- } finally {
- StreamUtil.closeQuietly(stream);
}
}
mTabsToSave.clear();

Powered by Google App Engine
This is Rietveld 408576698