mash: Implement restore on item click.

mash: Implement restore on item click.

BUG=none

Committed: https://crrev.com/95066c78d1017042d409ec707e218958fde15876
Cr-Commit-Position: refs/heads/master@{#404574}

[Elliot Glaysher, 2016-07-08 22:09:34]

erg@chromium.org changed reviewers:
+ msw@chromium.org

[Elliot Glaysher, 2016-07-08 22:09:35]

https://codereview.chromium.org/2138483002/diff/1/ash/sysui/shelf_delegate_mu...
File ash/sysui/shelf_delegate_mus.cc (right):

https://codereview.chromium.org/2138483002/diff/1/ash/sysui/shelf_delegate_mu...
ash/sysui/shelf_delegate_mus.cc:114:
user_window_controller_->ActivateUserWindow(
This is an attempt to make this more like
browser_shortcut_launcher_item_controller.cc. That implementation of
ItemSelected() only calls Activate() on the selected window which attempts to
Activate() a window instead. Other changes in this patch are to make the
ActivateUserWindow() show the window if it's hidden like it's current non-mus
counterpart.

(It also does other things like minimizing a window if it is active; I'm punting
on that for now.)

[msw, 2016-07-08 22:34:51]

lgtm

https://codereview.chromium.org/2138483002/diff/1/ash/mus/user_window_control...
File ash/mus/user_window_controller_impl.cc (right):

https://codereview.chromium.org/2138483002/diff/1/ash/mus/user_window_control...
ash/mus/user_window_controller_impl.cc:203: if (window->visible() == false)
optional nit: skip the check?

https://codereview.chromium.org/2138483002/diff/1/ash/sysui/shelf_delegate_mu...
File ash/sysui/shelf_delegate_mus.cc (right):

https://codereview.chromium.org/2138483002/diff/1/ash/sysui/shelf_delegate_mu...
ash/sysui/shelf_delegate_mus.cc:114:
user_window_controller_->ActivateUserWindow(
On 2016/07/08 22:09:35, Elliot Glaysher wrote:
> This is an attempt to make this more like
> browser_shortcut_launcher_item_controller.cc. That implementation of
> ItemSelected() only calls Activate() on the selected window which attempts to
> Activate() a window instead. Other changes in this patch are to make the
> ActivateUserWindow() show the window if it's hidden like it's current non-mus
> counterpart.
> 
> (It also does other things like minimizing a window if it is active; I'm
punting
> on that for now.)

Acknowledged.

[Elliot Glaysher, 2016-07-08 22:38:55]

Description was changed from

==========
mash: Implement restore on item click.

BUG=
==========

to

==========
mash: Implement restore on item click.

BUG=none
==========

[Elliot Glaysher, 2016-07-08 22:40:41]

erg@chromium.org changed reviewers:
+ dcheng@chromium.org, jamescook@chromium.org

[Elliot Glaysher, 2016-07-08 22:40:42]

+jamescook: OWNERS stamp
+dcheng: just renamed a method in the mojom.

[James Cook, 2016-07-08 22:56:32]

lgtm

[dcheng, 2016-07-09 01:45:11]

mojo lgtm

[Elliot Glaysher, 2016-07-09 23:19:17]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2016-07-09 23:19:18]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2138483002/#ps20001
(title: "skip the redundant check")

[commit-bot: I haz the power, 2016-07-09 23:19:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-10 00:13:55]

Description was changed from

==========
mash: Implement restore on item click.

BUG=none
==========

to

==========
mash: Implement restore on item click.

BUG=none
==========

[commit-bot: I haz the power, 2016-07-10 00:13:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-10 00:14:00]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-10 00:16:48]

Description was changed from

==========
mash: Implement restore on item click.

BUG=none
==========

to

==========
mash: Implement restore on item click.

BUG=none

Committed: https://crrev.com/95066c78d1017042d409ec707e218958fde15876
Cr-Commit-Position: refs/heads/master@{#404574}
==========

[commit-bot: I haz the power, 2016-07-10 00:16:49]

Patchset 2 (id:??) landed as
https://crrev.com/95066c78d1017042d409ec707e218958fde15876
Cr-Commit-Position: refs/heads/master@{#404574}