Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2138463002: DevTools: unquote 'true' in the protocol definition. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: unquote 'true' in the protocol definition. BUG=625341 TBR=dgozman Committed: https://crrev.com/9f1958faeca7fab46f0974251e2d22b3b39ccfdb Cr-Commit-Position: refs/heads/master@{#404543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pfeldman
4 years, 5 months ago (2016-07-08 21:37:39 UTC) #2
pfeldman
4 years, 5 months ago (2016-07-08 21:37:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138463002/1
4 years, 5 months ago (2016-07-08 21:38:40 UTC) #6
nojvek
Pavel, Thanks for the quick fix.
4 years, 5 months ago (2016-07-08 21:45:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-09 00:17:37 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-09 00:17:50 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-09 00:20:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f1958faeca7fab46f0974251e2d22b3b39ccfdb
Cr-Commit-Position: refs/heads/master@{#404543}

Powered by Google App Engine
This is Rietveld 408576698