Add unit test for mus_demo.

Add unit test for mus_demo.

The unit test starts mus demo and checks that it successfully draws
compositor frames. Test is not setup to run on bots yet.

There is a problem where the WindowTree name isn't set to the client
name when the WindowTree is created for a WindowManager. Once this is
fixed EnsureClientHasDrawnWindow() should be using "mojo:mus_demo" as
the name it's looking for.

Also use this chance to fix some namespace stuff for MusDemo.

BUG=611473
Committed: https://crrev.com/e4f4e191d33ee769ea258ca885938fa9ee3bf278
Cr-Commit-Position: refs/heads/master@{#405493}

[kylechar, 2016-07-08 18:16:09]

kylechar@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2016-07-08 21:38:33]

lgtm. 

I presume that we can get this on the oxygen builder yes?

https://codereview.chromium.org/2138433002/diff/20001/services/ui/demo/mus_de...
File services/ui/demo/mus_demo_unittests.cc (right):

https://codereview.chromium.org/2138433002/diff/20001/services/ui/demo/mus_de...
services/ui/demo/mus_demo_unittests.cc:25: class MusDemoTest : public
shell::test::ServiceTest {
Given that we renamed mus to services/ui -- maybe this needs a different name.
Challenge what should this different name be? I started a thread.

[kylechar, 2016-07-13 13:55:32]

I think we should be able to get the test running on some bots. The only thing
I'm not 100% on is having it run with X11 as most tests use headless platform
(which is useless for this test) but hopefully it just works with the right
flag.

https://codereview.chromium.org/2138433002/diff/20001/services/ui/demo/mus_de...
File services/ui/demo/mus_demo_unittests.cc (right):

https://codereview.chromium.org/2138433002/diff/20001/services/ui/demo/mus_de...
services/ui/demo/mus_demo_unittests.cc:25: class MusDemoTest : public
shell::test::ServiceTest {
On 2016/07/08 21:38:32, rjkroege wrote:
> Given that we renamed mus to services/ui -- maybe this needs a different name.
> Challenge what should this different name be? I started a thread.

I see the thread. Hmmm, UIServiceDemo doesn't have quite the same ring to it.

[rjkroege, 2016-07-13 23:10:22]

On 2016/07/13 13:55:32, kylechar wrote:
> I think we should be able to get the test running on some bots. The only thing
> I'm not 100% on is having it run with X11 as most tests use headless platform
> (which is useless for this test) but hopefully it just works with the right
> flag.
> 
>
https://codereview.chromium.org/2138433002/diff/20001/services/ui/demo/mus_de...
> File services/ui/demo/mus_demo_unittests.cc (right):
> 
>
https://codereview.chromium.org/2138433002/diff/20001/services/ui/demo/mus_de...
> services/ui/demo/mus_demo_unittests.cc:25: class MusDemoTest : public
> shell::test::ServiceTest {
> On 2016/07/08 21:38:32, rjkroege wrote:
> > Given that we renamed mus to services/ui -- maybe this needs a different
name.
> > Challenge what should this different name be? I started a thread.
> 
> I see the thread. Hmmm, UIServiceDemo doesn't have quite the same ring to it.

Leave it be.

[kylechar, 2016-07-14 13:02:54]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-07-14 13:03:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 13:04:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 13:04:34]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[kylechar, 2016-07-14 13:26:33]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-07-14 13:26:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org
Link to the patchset: https://codereview.chromium.org/2138433002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-14 13:26:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 14:45:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 14:47:19]

Description was changed from

==========
Add unit test for mus_demo.

The unit test starts mus demo and checks that it successfully draws
compositor frames. Test is not setup to run on bots yet.

There is a problem where the WindowTree name isn't set to the client
name when the WindowTree is created for a WindowManager. Once this is
fixed EnsureClientHasDrawnWindow() should be using "mojo:mus_demo" as
the name it's looking for.

Also use this chance to fix some namespace stuff for MusDemo.

BUG=611473
==========

to

==========
Add unit test for mus_demo.

The unit test starts mus demo and checks that it successfully draws
compositor frames. Test is not setup to run on bots yet.

There is a problem where the WindowTree name isn't set to the client
name when the WindowTree is created for a WindowManager. Once this is
fixed EnsureClientHasDrawnWindow() should be using "mojo:mus_demo" as
the name it's looking for.

Also use this chance to fix some namespace stuff for MusDemo.

BUG=611473

Committed: https://crrev.com/e4f4e191d33ee769ea258ca885938fa9ee3bf278
Cr-Commit-Position: refs/heads/master@{#405493}
==========

[commit-bot: I haz the power, 2016-07-14 14:47:21]

Patchset 3 (id:??) landed as
https://crrev.com/e4f4e191d33ee769ea258ca885938fa9ee3bf278
Cr-Commit-Position: refs/heads/master@{#405493}