Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 213843002: Building env_chromium_unittests for Android. (Closed)

Created:
6 years, 8 months ago by cmumford
Modified:
6 years, 8 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Building env_chromium_unittests for Android. The LevelDB Chromium environment unit tests (AKA env_chromium_unittests) were neither compiling for Android, nor was an APK produced that could be run. BUG=356882 R=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260148

Patch Set 1 #

Patch Set 2 : Eliminated redundant condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M third_party/leveldatabase/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/leveldatabase/env_chromium_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/leveldatabase/leveldatabase.gyp View 1 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
cmumford
Successfully ran on my Nexus 7.
6 years, 8 months ago (2014-03-26 23:16:01 UTC) #1
jsbell
lgtm - this seems to match the pattern used for other tests
6 years, 8 months ago (2014-03-26 23:25:08 UTC) #2
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 8 months ago (2014-03-27 00:34:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213843002/1
6 years, 8 months ago (2014-03-27 00:37:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 01:56:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=58624
6 years, 8 months ago (2014-03-27 01:56:26 UTC) #6
cmumford
Didn't realize that I added a second condition to wrap the env_chromium_unittests_apk. The Windows bot ...
6 years, 8 months ago (2014-03-27 15:54:18 UTC) #7
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 8 months ago (2014-03-27 19:56:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213843002/20001
6 years, 8 months ago (2014-03-27 19:59:58 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 02:29:38 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=289914
6 years, 8 months ago (2014-03-28 02:29:38 UTC) #11
jsbell
6 years, 8 months ago (2014-03-28 16:12:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 manually as r260148 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698