Issue 2138423002: Correct install sysroot script logs/comments

Issue 2138423002: Correct install sysroot script logs/comments (Closed)

Created:
4 years, 5 months ago by apatole

Modified:
4 years, 5 months ago

Reviewers:
Lei Zhang, Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Correct install sysroot script logs/comments Since we have Jessie sysroot for arm64 linux and Wheezy sysroots for others, log/comment lines in install-sysroot script need to be modified to match this behavior. BUG=613452 R=thestig@chromium.org, thakis@chromium.org Committed: https://crrev.com/814e497b3425ab0d25585c3f89f61e35e5ab6bdf Cr-Commit-Position: refs/heads/master@{#404841}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	build/linux/sysroot_scripts/install-sysroot.py	View		4 chunks	+14 lines, -10 lines	0 comments	Download

Total messages: 8 (2 generated)

apatole

PTAL, sorry I forgot to modify these comments/logs in last patch and just realized it ...

4 years, 5 months ago (2016-07-12 10:47:51 UTC) #1

Nico

lgtm, but thestig knows this file much better than I do. Thanks for working on ...

4 years, 5 months ago (2016-07-12 17:56:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138423002/1

4 years, 5 months ago (2016-07-12 19:24:28 UTC) #5

commit-bot: I haz the power

4 years, 5 months ago (2016-07-12 21:55:55 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/814e497b3425ab0d25585c3f89f61e35e5ab6bdf
Cr-Commit-Position: refs/heads/master@{#404841}