Revert of Add CheckOCSPDateValid() to net/cert/internal

Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001 of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows

Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
>
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
>
> BUG=598021
>
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021
Committed: https://crrev.com/144744b5cced306a06d167f2e34610378f6336ea
Cr-Commit-Position: refs/heads/master@{#404802}

[engedy, 2016-07-12 10:01:02]

Created Revert of Add CheckOCSPDateValid() to net/cert/internal

[engedy, 2016-07-12 10:02:12]

Failure run:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...

Details:

EncodeValuesTest.EncodeTimeAfterTimeTMax (run #1):
[ RUN      ] EncodeValuesTest.EncodeTimeAfterTimeTMax
../../net/der/encode_values_unittest.cc:51: Failure
Value of: generalized_time.year
  Actual: 1902
Expected: 2039
../../net/der/encode_values_unittest.cc:52: Failure
Value of: generalized_time.month
  Actual: '' (11, 0xB)
Expected: 1
../../net/der/encode_values_unittest.cc:53: Failure
Value of: generalized_time.day
  Actual: '' (25)
Expected: 1
../../net/der/encode_values_unittest.cc:54: Failure
Value of: generalized_time.hours
  Actual: '' (17)
Expected: 0
../../net/der/encode_values_unittest.cc:55: Failure
Value of: generalized_time.minutes
  Actual: '' (31)
Expected: 0
../../net/der/encode_values_unittest.cc:56: Failure
Value of: generalized_time.seconds
  Actual: ',' (44, 0x2C)
Expected: 0
[  FAILED  ] EncodeValuesTest.EncodeTimeAfterTimeTMax (1 ms)

EncodeValuesTest.EncodeTimeFromBeforeWindows (run #1):
[ RUN      ] EncodeValuesTest.EncodeTimeFromBeforeWindows
../../net/der/encode_values_unittest.cc:36: Failure
Value of: generalized_time.year
  Actual: 1978
Expected: 1570
../../net/der/encode_values_unittest.cc:37: Failure
Value of: generalized_time.month
  Actual: '?\x4' (4)
Expected: 1
../../net/der/encode_values_unittest.cc:38: Failure
Value of: generalized_time.day
  Actual: '' (22)
Expected: 1
../../net/der/encode_values_unittest.cc:39: Failure
Value of: generalized_time.hours
  Actual: '' (19)
Expected: 0
../../net/der/encode_values_unittest.cc:40: Failure
Value of: generalized_time.minutes
  Actual: '' (24)
Expected: 0
../../net/der/encode_values_unittest.cc:41: Failure
Value of: generalized_time.seconds
  Actual: '0' (48, 0x30)
Expected: 0
[  FAILED  ] EncodeValuesTest.EncodeTimeFromBeforeWindows (2 ms)

[engedy, 2016-07-12 10:02:42]

Description was changed from

==========
Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001
of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows


Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
> 
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
> 
> BUG=598021
> 
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@goo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021
==========

to

==========
Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001
of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows


Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
> 
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
> 
> BUG=598021
> 
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@goo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=598021
==========

[engedy, 2016-07-12 10:03:05]

Description was changed from

==========
Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001
of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows


Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
> 
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
> 
> BUG=598021
> 
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@goo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=598021
==========

to

==========
Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001
of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows


Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
> 
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
> 
> BUG=598021
> 
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@goo...
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=598021
==========

[engedy, 2016-07-12 10:03:37]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2016-07-12 10:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[engedy, 2016-07-12 11:16:13]

Description was changed from

==========
Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001
of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows


Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
> 
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
> 
> BUG=598021
> 
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@goo...
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=598021
==========

to

==========
Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001
of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows


Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
> 
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
> 
> BUG=598021
> 
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@goo...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021
==========

[engedy, 2016-07-12 11:16:18]

The CQ bit was unchecked by engedy@chromium.org

[engedy, 2016-07-12 11:16:21]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2016-07-12 11:17:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 11:18:17]

Description was changed from

==========
Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001
of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows


Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
> 
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
> 
> BUG=598021
> 
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@goo...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021
==========

to

==========
Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001
of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows


Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
> 
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
> 
> BUG=598021
> 
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@goo...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021
==========

[commit-bot: I haz the power, 2016-07-12 11:18:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-12 11:18:38]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-12 11:20:03]

Description was changed from

==========
Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001
of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows


Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
> 
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
> 
> BUG=598021
> 
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@goo...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021
==========

to

==========
Revert of Add CheckOCSPDateValid() to net/cert/internal (patchset #13 id:240001
of https://codereview.chromium.org/2091103002/ )

Reason for revert:
Causes reliable test failures on Linux Tests (dbg)(1)(32):

EncodeValuesTest.EncodeTimeAfterTimeTMax
EncodeValuesTest.EncodeTimeFromBeforeWindows

Original issue's description:
> Add CheckOCSPDateValid() to net/cert/internal
>
> Intended to be used internally by certificate validation as part of OCSP
> validity checks and Expect-Staple.
>
> BUG=598021
>
> Committed: https://crrev.com/687cf9fffda1a7eb45c80a596fa4f9e3e524f0e4
> Cr-Commit-Position: refs/heads/master@{#404708}

TBR=rsleevi@chromium.org,svaldez@chromium.org,estark@chromium.org,dadrian@goo...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598021

Committed: https://crrev.com/144744b5cced306a06d167f2e34610378f6336ea
Cr-Commit-Position: refs/heads/master@{#404802}
==========

[commit-bot: I haz the power, 2016-07-12 11:20:04]

Patchset 1 (id:??) landed as
https://crrev.com/144744b5cced306a06d167f2e34610378f6336ea
Cr-Commit-Position: refs/heads/master@{#404802}

[dadrian, 2016-07-12 17:06:51]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2144693002/ by dadrian@google.com.

The reason for reverting is: Fix broken 32-bit tests.

[Ryan Sleevi, 2016-07-12 17:41:22]

Shouldn't that bot be removed, since we no longer officially support 32-bit
Linux?

Or do we?

[engedy, 2016-07-12 17:48:32]

I believe we do intend to continue supporting building Chromium on Linux 32-bit,
just not release official Chrome builds anymore on that platform.

See:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/FoE6sL-p6oU