Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2138363002:
Throw exception instead of crashing when creating a wrong wrapper (Closed)
|
Created:
4 years, 5 months ago by jochen (gone - plz use gerrit) Modified:
4 years, 5 months ago Reviewers:
haraken CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionThrow exception instead of crashing when creating a wrong wrapper
This can happen when a frame changes its domain via document.domain but
already had access to objects from a previously same-origin frame.
BUG=585871
R=haraken@chromium.org
Committed: https://crrev.com/f158bedd66697cf6d817387065d1d086919cff04
Cr-Commit-Position: refs/heads/master@{#404874}
Patch Set 1 #
Messages
Total messages: 23 (10 generated)
LGTM
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Throw exception instead of crashing when creating a wrong wrapper This can happen when a frame changes its domain via document.domain but already had access to objects from a previously same-origin frame. BUG=585871 R=haraken@chromium.org ========== to ========== Throw exception instead of crashing when creating a wrong wrapper This can happen when a frame changes its domain via document.domain but already had access to objects from a previously same-origin frame. BUG=585871 R=haraken@chromium.org Committed: https://crrev.com/f158bedd66697cf6d817387065d1d086919cff04 Cr-Commit-Position: refs/heads/master@{#404874} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f158bedd66697cf6d817387065d1d086919cff04 Cr-Commit-Position: refs/heads/master@{#404874} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
