Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2138333002: Cleaned up simple-keyframes.html test (Closed)

Created:
4 years, 5 months ago by sashab
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleaned up simple-keyframes.html test Cleaned up simple-keyframes.html test to better match W3C standards. Part of web animations test burndown. BUG=623437 Committed: https://crrev.com/b89e8e2dd7b68b051fc18f04dc8106aea3720b64 Cr-Commit-Position: refs/heads/master@{#405373}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/web-animations-api/w3c/simple-keyframes.html View 1 1 chunk +44 lines, -31 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
sashab
4 years, 5 months ago (2016-07-12 04:49:25 UTC) #2
alancutter (OOO until 2018)
We should just add these to keyframe-utils.js gKeyframeSequenceTests. I don't think they're exactly covered by ...
4 years, 5 months ago (2016-07-12 06:12:04 UTC) #3
sashab
Hey Suzie - not going to finish this one, ptal at Alan's comments
4 years, 5 months ago (2016-07-13 01:52:22 UTC) #5
suzyh_UTC10 (ex-contributor)
On 2016/07/13 at 01:52:22, sashab wrote: > Hey Suzie - not going to finish this ...
4 years, 5 months ago (2016-07-13 03:00:00 UTC) #6
suzyh_UTC10 (ex-contributor)
Having looked over this, I think we should submit this as-is (after fixing the one ...
4 years, 5 months ago (2016-07-13 23:10:34 UTC) #7
sashab
Sgtm! Done :D
4 years, 5 months ago (2016-07-13 23:34:04 UTC) #8
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-13 23:34:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138333002/20001
4 years, 5 months ago (2016-07-13 23:35:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 00:54:50 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 00:54:57 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 00:56:28 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b89e8e2dd7b68b051fc18f04dc8106aea3720b64
Cr-Commit-Position: refs/heads/master@{#405373}

Powered by Google App Engine
This is Rietveld 408576698