Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 213833019: Enable Repaint-After-Layout by default. (Closed)

Created:
6 years, 8 months ago by dsinclair
Modified:
6 years, 8 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Enable Repaint-After-Layout by default. This CL enables the new repaint-after-layout feature. This changes the way that we do repainting in Blink and has the potential to cause under-painting. There are know over-painting issues. The over-painting LayoutTests are being tracked in crbug.com/340670. If you see underpainting issues, please try with --disable-repaint-after-layout and see if the issue persists. BUG=320139 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170660

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Updating expectations to pass lint. #

Patch Set 5 : Merge again ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +119 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dsinclair
PTAL.
6 years, 8 months ago (2014-04-01 19:22:09 UTC) #1
ojan
lgtm
6 years, 8 months ago (2014-04-01 21:45:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/213833019/40001
6 years, 8 months ago (2014-04-01 22:42:07 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 22:53:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-01 22:53:15 UTC) #5
dsinclair
Hm, why did this let me upload if the test expectations file is wrong? I'll ...
6 years, 8 months ago (2014-04-01 23:05:24 UTC) #6
Julien - ping for review
On 2014/04/01 23:05:24, dsinclair wrote: > Hm, why did this let me upload if the ...
6 years, 8 months ago (2014-04-02 00:54:49 UTC) #7
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 8 months ago (2014-04-02 14:03:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/213833019/80001
6 years, 8 months ago (2014-04-02 14:03:40 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 15:17:23 UTC) #10
Message was sent while issue was closed.
Change committed as 170660

Powered by Google App Engine
This is Rietveld 408576698