Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: ui/wm/public/tooltip_client.h

Issue 213833018: Aura tooltips do not move on mouse move in case of many neighboring views with the same label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change the unique id of tooltip text from void** to void* Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/wm/public/tooltip_client.h
diff --git a/ui/wm/public/tooltip_client.h b/ui/wm/public/tooltip_client.h
index f592b21a18a5ef4072a3e139907419e4c4340366..cb1d5a6879b191ad200042dcfcc666827ea0629f 100644
--- a/ui/wm/public/tooltip_client.h
+++ b/ui/wm/public/tooltip_client.h
@@ -36,8 +36,17 @@ AURA_EXPORT void SetTooltipClient(Window* root_window,
TooltipClient* client);
AURA_EXPORT TooltipClient* GetTooltipClient(Window* root_window);
-AURA_EXPORT void SetTooltipText(Window* window, base::string16* tooltip_text);
+// Sets the |tooltip_text| and |id| pointers as properties of the |window|.
sky 2014/06/02 15:39:47 This is rather confusing. How about: Sets the text
+// Those are later retrievable by GetTooltipText and GetTooltip id, given
+// the appropriate window pointer. |id| is optionally non-null and is used as
+// an uniqueness indicator for different tooltips - in case its value changes
+// between two points, the tooltips at these two points are treated as separate
+// entities.
+AURA_EXPORT void SetTooltipText(Window* window,
+ base::string16* tooltip_text);
+AURA_EXPORT void UpdateTooltipId(Window* window, void* id);
AURA_EXPORT const base::string16 GetTooltipText(Window* window);
+AURA_EXPORT const void* GetTooltipId(Window* window);
} // namespace client
} // namespace aura

Powered by Google App Engine
This is Rietveld 408576698