ui/views/corewm/tooltip_controller.h - Issue 213833018: Aura tooltips do not move on mouse move in case of many neighboring views with the same label

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/corewm/tooltip_controller.h

Issue 213833018: Aura tooltips do not move on mouse move in case of many neighboring views with the same label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sanity fixups Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | ui/views/corewm/tooltip_controller.cc » ('j') | ui/views/corewm/tooltip_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/corewm/tooltip_controller.h

diff --git a/ui/views/corewm/tooltip_controller.h b/ui/views/corewm/tooltip_controller.h

index 9815df1817a46d4f76cf17c459310b0502a34ead..1992443c7bbe62aea5c4cd0e836e13f8847a86b5 100644

--- a/ui/views/corewm/tooltip_controller.h

+++ b/ui/views/corewm/tooltip_controller.h

@@ -61,7 +61,8 @@ class VIEWS_EXPORT TooltipController : public aura::client::TooltipClient,

void TooltipShownTimerFired();

// Updates the tooltip if required (if there is any change in the tooltip

- // text or the aura::Window.

+ // text or the aura::Window). If |force| is true the tooltip will be updated

sky 2014/04/23 20:08:46 There is no force here.

Mikus 2014/04/24 08:39:56 Done.

+ // regardless of these conditions.

void UpdateIfRequired();

// Only used in tests.

@@ -81,6 +82,7 @@ class VIEWS_EXPORT TooltipController : public aura::client::TooltipClient,

aura::Window* tooltip_window_;

base::string16 tooltip_text_;

+ const void* tooltip_unique_;

// These fields are for tracking state when the user presses a mouse button.

aura::Window* tooltip_window_at_mouse_press_;