Aura tooltips do not move on mouse move in case of many neighboring views with the same label

ui/views/widget/tooltip_manager_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/tooltip_manager_aura.h"
 
 #include "base/logging.h"
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/screen.h"
+#include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 #include "ui/wm/public/tooltip_client.h"
 
 namespace views {
 
 // static
 int TooltipManager::GetTooltipHeight() {
   // Not used for linux and chromeos.
   NOTIMPLEMENTED();
   return 0;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // TooltipManagerAura public:
 
-TooltipManagerAura::TooltipManagerAura(Widget* widget) : widget_(widget) {
+TooltipManagerAura::TooltipManagerAura(Widget* widget)
+    : widget_(widget) {
   aura::client::SetTooltipText(GetWindow(), &tooltip_text_);
 }
 
 TooltipManagerAura::~TooltipManagerAura() {
   aura::client::SetTooltipText(GetWindow(), NULL);
 }
 
 // static
 const gfx::FontList& TooltipManagerAura::GetDefaultFontList() {
   return ui::ResourceBundle::GetSharedInstance().GetFontList(
@@ skipping 75 matching lines @@
 View* TooltipManagerAura::GetViewUnderPoint(const gfx::Point& point) {
   View* root_view = widget_->GetRootView();
   if (root_view)
     return root_view->GetTooltipHandlerForPoint(point);
   return NULL;
 }
 
 void TooltipManagerAura::UpdateTooltipForTarget(View* target,
                                                 const gfx::Point& point,
                                                 aura::Window* root_window) {
+  bool related = false;
   if (target) {
     gfx::Point view_point = point;
     View::ConvertPointFromWidget(target, &view_point);
     base::string16 new_tooltip_text;
     if (!target->GetTooltipText(view_point, &new_tooltip_text))
       tooltip_text_.clear();
     else
       tooltip_text_ = new_tooltip_text;
+
+    gfx::Point target_rect_origin_in_screen;

[sky, 2014/04/10 16:12:08]

This is a pain for each site to have to deal with. I think a better approach is
for SetTooltipText to take an additional void* that is used for uniqueness.
Views would pass in the target.

+    views::View::ConvertPointToScreen(target, &target_rect_origin_in_screen);
+
+    gfx::Rect target_rect_in_screen(
+        target_rect_origin_in_screen, target->bounds().size());
+
+    const bool bounds_different =
+        target_rect_in_screen != origin_bounds_;
+    const bool target_contains_origin =
+        target_rect_in_screen.Contains(origin_bounds_);
+    const bool origin_contains_target =
+        origin_bounds_.Contains(target_rect_in_screen);
+
+    related =
+        !bounds_different || target_contains_origin || origin_contains_target;
+
+    origin_bounds_ = target_rect_in_screen;
   } else {
     tooltip_text_.clear();
+    origin_bounds_ = gfx::Rect();
   }
-  aura::client::GetTooltipClient(root_window)->UpdateTooltip(GetWindow());
+
+  aura::client::GetTooltipClient(root_window)
+      ->UpdateTooltip(GetWindow(), !related);
 }
 
 aura::Window* TooltipManagerAura::GetWindow() {
   return widget_->GetNativeView();
 }
 
 }  // namespace views.