Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 213833018: Aura tooltips do not move on mouse move in case of many neighboring views with the same label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Write unit test for the case when a tooltip moves from one view to another with the same tooltip bu… Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_aura.h" 5 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
(...skipping 976 matching lines...) Expand 10 before | Expand all | Expand 10 after
987 delete window_; 987 delete window_;
988 } 988 }
989 989
990 void RenderWidgetHostViewAura::SetTooltipText( 990 void RenderWidgetHostViewAura::SetTooltipText(
991 const base::string16& tooltip_text) { 991 const base::string16& tooltip_text) {
992 tooltip_ = tooltip_text; 992 tooltip_ = tooltip_text;
993 aura::Window* root_window = window_->GetRootWindow(); 993 aura::Window* root_window = window_->GetRootWindow();
994 aura::client::TooltipClient* tooltip_client = 994 aura::client::TooltipClient* tooltip_client =
995 aura::client::GetTooltipClient(root_window); 995 aura::client::GetTooltipClient(root_window);
996 if (tooltip_client) { 996 if (tooltip_client) {
997 tooltip_client->UpdateTooltip(window_); 997 tooltip_client->UpdateTooltip(window_, false);
998 // Content tooltips should be visible indefinitely. 998 // Content tooltips should be visible indefinitely.
999 tooltip_client->SetTooltipShownTimeout(window_, 0); 999 tooltip_client->SetTooltipShownTimeout(window_, 0);
1000 } 1000 }
1001 } 1001 }
1002 1002
1003 void RenderWidgetHostViewAura::SelectionChanged(const base::string16& text, 1003 void RenderWidgetHostViewAura::SelectionChanged(const base::string16& text,
1004 size_t offset, 1004 size_t offset,
1005 const gfx::Range& range) { 1005 const gfx::Range& range) {
1006 RenderWidgetHostViewBase::SelectionChanged(text, offset, range); 1006 RenderWidgetHostViewBase::SelectionChanged(text, offset, range);
1007 1007
(...skipping 2211 matching lines...) Expand 10 before | Expand all | Expand 10 after
3219 RenderWidgetHost* widget) { 3219 RenderWidgetHost* widget) {
3220 return new RenderWidgetHostViewAura(widget); 3220 return new RenderWidgetHostViewAura(widget);
3221 } 3221 }
3222 3222
3223 // static 3223 // static
3224 void RenderWidgetHostViewPort::GetDefaultScreenInfo(WebScreenInfo* results) { 3224 void RenderWidgetHostViewPort::GetDefaultScreenInfo(WebScreenInfo* results) {
3225 GetScreenInfoForWindow(results, NULL); 3225 GetScreenInfoForWindow(results, NULL);
3226 } 3226 }
3227 3227
3228 } // namespace content 3228 } // namespace content
OLDNEW
« no previous file with comments | « ash/shell/lock_view.cc ('k') | ui/views/corewm/tooltip.h » ('j') | ui/views/corewm/tooltip.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698