Aura tooltips do not move on mouse move in case of many neighboring views with the same label

ui/wm/public/tooltip_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_WM_PUBLIC_TOOLTIP_CLIENT_H_
 #define UI_WM_PUBLIC_TOOLTIP_CLIENT_H_
 
 #include "ui/aura/aura_export.h"
 #include "ui/gfx/font.h"
 
@@ skipping 18 matching lines @@
   virtual void SetTooltipsEnabled(bool enable) = 0;
 
  private:
   friend class ScopedTooltipDisabler;
 };
 
 AURA_EXPORT void SetTooltipClient(Window* root_window,
                                   TooltipClient* client);
 AURA_EXPORT TooltipClient* GetTooltipClient(Window* root_window);
 
-AURA_EXPORT void SetTooltipText(Window* window, base::string16* tooltip_text);
+AURA_EXPORT void SetTooltipText(Window* window,
+                                base::string16* tooltip_text,
+                                void** tooltip_unique);

[sky, 2014/04/23 20:08:46]

Why does this need to be a void**? Why not void*? Also, document what it is. I
suggest naming it id as well.

[Mikus, 2014/04/24 08:39:56]

I want to reference a void* field of tooltip_manager_aura, hence void** (just
like it's done with tooltip_text_). Otherwise it's impossible (I cannot cast
reinterpret_cast<void*>(*tooltip_id_) since *tooltip_id_ is an invalid
indirection.

I named it ID and documented it, though.

[sky, 2014/04/24 16:19:44]

Just like you invoke SetTooltipText with a string*, not a string** this should
take a void*. It should be responsible for recognizing when the *id changes. It
should be told. In that case a void* is all you need.

 AURA_EXPORT const base::string16 GetTooltipText(Window* window);
+AURA_EXPORT const void* GetTooltipUnique(Window* window);

[sky, 2014/04/23 20:08:46]

GetTooltipId?

[Mikus, 2014/04/24 08:39:56]

Done.

 
 }  // namespace client
 }  // namespace aura
 
 #endif  // UI_WM_PUBLIC_TOOLTIP_CLIENT_H_