src/builtins.cc - Issue 213833008: Fix left trimming check for large objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 213833008: Fix left trimming check for large objects (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index fd4723f62ce4c91d3c5f35664330beec00da0367..7be7233c2109599585c266ddb20d78f4e18bc687 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -554,7 +554,7 @@ BUILTIN(ArrayShift) {

first = isolate->factory()->undefined_value();

}

- if (!heap->CanMoveObjectStart(*elms_obj)) {

+ if (heap->CanMoveObjectStart(*elms_obj)) {

array->set_elements(LeftTrimFixedArray(heap, *elms_obj, 1));

} else {

// Shift the elements.

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-358090.js » ('j') | no next file with comments »