chrome/browser/ui/web_applications/web_app_ui.cc - Issue 213833005: Prevent SHChangeNotify on app list drag on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/web_applications/web_app_ui.cc

Issue 213833005: Prevent SHChangeNotify on app list drag on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/web_applications/web_app_ui.cc

diff --git a/chrome/browser/ui/web_applications/web_app_ui.cc b/chrome/browser/ui/web_applications/web_app_ui.cc

index 8d710541c0f0591539d5094bc543f4c122de1d1a..51e7e7ac79ae9b9209ab495e0b22ae44a1d74ef8 100644

--- a/chrome/browser/ui/web_applications/web_app_ui.cc

+++ b/chrome/browser/ui/web_applications/web_app_ui.cc

@@ -291,8 +291,8 @@ void UpdateShortcutWorker::UpdateShortcutsOnFileThread() {

return;

}

- base::FilePath icon_file = web_app_path.Append(file_name_).ReplaceExtension(

- FILE_PATH_LITERAL(".ico"));

+ base::FilePath icon_file =

+ web_app::internals::GetIconFilePath(web_app_path, shortcut_info_.title);

web_app::internals::CheckAndSaveIcon(icon_file, shortcut_info_.favicon);

// Update existing shortcuts' description, icon and app id.