Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2138323002: Add output_all_resource_defines=false to theme_resources.grd. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
3 years, 3 months ago
Reviewers:
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add output_all_resource_defines=false to theme_resources.grd. BUG=627301

Patch Set 1 #

Patch Set 2 : download bits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -15 lines) Patch
M apps/BUILD.gn View 1 chunk +6 lines, -4 lines 0 comments Download
M apps/apps.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_commands.cc View 1 2 chunks +29 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
Lei Zhang
3 years, 3 months ago (2017-09-13 06:55:38 UTC) #1 
Description was changed from

==========
Add output_all_resource_defines=false to theme_resources.grd.

BUG=627301
==========

to

==========
Add output_all_resource_defines=false to theme_resources.grd.

BUG=627301
==========

Powered by Google App Engine
This is Rietveld 408576698