Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2138313002: Revert of Flip remaining main Mac bots to GN. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip remaining main Mac bots to GN. (patchset #1 id:1 of https://codereview.chromium.org/2136293002/ ) Reason for revert: "Mac" builder on /p/chromium fails follow-up ninja build claiming that things are dirty: https://build.chromium.org/p/chromium/builders/Mac/builds/17564/steps/compile/logs/stdio The official.desktop.continuous builder is breaking due to the missing remoting crashreporting link that I had thought I fixed but maybe forgot to land ... Original issue's description: > Flip remaining main Mac bots to GN. > > This flips the remaining main Mac bots to GN, e.g.: > > - chromium > - Mac > - chromium.chrome > - Google Mac > - chromium.perf > - Mac Builder > - official.desktop > - mac64 > - official.desktop.continuous > - mac trunk > > There are various FYI and memory builders still, plus the GYP > builder on the chromium.mac waterfall. > > R=rsesek@chromium.org > NOTRY=true > BUG=618468 > > Committed: https://crrev.com/f7d150aa0ad0c54760d5593ac04afee50e1e5286 > Cr-Commit-Position: refs/heads/master@{#404744} TBR=rsesek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618468 Committed: https://crrev.com/f746c62413f7db8758bb21750af0d98938f3308a Cr-Commit-Position: refs/heads/master@{#404765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M tools/mb/mb_config.pyl View 6 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dirk Pranke
Created Revert of Flip remaining main Mac bots to GN.
4 years, 5 months ago (2016-07-12 01:49:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138313002/1
4 years, 5 months ago (2016-07-12 01:50:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 01:51:24 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 01:51:32 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 01:53:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f746c62413f7db8758bb21750af0d98938f3308a
Cr-Commit-Position: refs/heads/master@{#404765}

Powered by Google App Engine
This is Rietveld 408576698