Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 213823002: Don't pass the hole to SetElement when creating Array.observe change records (Closed)

Created:
6 years, 9 months ago by adamk
Modified:
6 years, 9 months ago
Reviewers:
rossberg, rafaelw
CC:
v8-dev
Visibility:
Public.

Description

Don't pass the hole to SetElement when creating Array.observe change records Also added comments to remind us why we were using the hole here in the first place (it's used for the case where Object.observe, rather than Array.observe, has been called on Array that's undergoing truncation). BUG=356589 LOG=N R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/objects.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-356589.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
6 years, 9 months ago (2014-03-26 23:05:49 UTC) #1
rossberg
LGTM
6 years, 9 months ago (2014-03-27 08:34:41 UTC) #2
adamk
6 years, 9 months ago (2014-03-27 18:29:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698