Prepare time-consistent-across-frames for upstreaming

Prepare time-consistent-across-frames for upstreaming

BUG=623437

[dstockwell, 2016-07-12 03:41:15]

dstockwell@chromium.org changed reviewers:
+ alancutter@chromium.org, suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-07-12 03:58:14]

lgtm

[alancutter (OOO until 2018), 2016-07-12 04:23:27]

https://codereview.chromium.org/2138153003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html
(right):

https://codereview.chromium.org/2138153003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html:23:
while (performance.now() - start < 30);
Can we use requestAnimationFrame instead of setTimeout and busy waits?

[dstockwell, 2016-07-12 04:34:01]

On 2016/07/12 at 04:23:27, alancutter wrote:
>
https://codereview.chromium.org/2138153003/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html
(right):
> 
>
https://codereview.chromium.org/2138153003/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html:23:
while (performance.now() - start < 30);
> Can we use requestAnimationFrame instead of setTimeout and busy waits?

No, this is not testing the time inside RAF which is frozen before the task even
begins. The synchronous waits are required to allow a possible tick inside the
task.

[suzyh_UTC10 (ex-contributor), 2016-07-13 07:32:38]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-07-13 07:32:39]

lgtm

[commit-bot: I haz the power, 2016-07-13 07:33:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 08:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 08:47:14]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[suzyh_UTC10 (ex-contributor), 2016-07-13 22:45:25]

https://codereview.chromium.org/2138153003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html
(right):

https://codereview.chromium.org/2138153003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html:26:
handle.step(() => assert_times_equals(delta, frameDelta);
Missed this the first time around. The function is assert_times_equal and
requires
<script src="../imported/wpt/web-animations/testcommon.js"></script>

[suzyh_UTC10 (ex-contributor), 2016-07-14 01:15:21]

On 2016/07/13 at 22:45:25, suzyh wrote:
>
https://codereview.chromium.org/2138153003/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html
(right):
> 
>
https://codereview.chromium.org/2138153003/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html:26:
handle.step(() => assert_times_equals(delta, frameDelta);
> Missed this the first time around. The function is assert_times_equal and
requires
> <script src="../imported/wpt/web-animations/testcommon.js"></script>

Closing in favour of https://codereview.chromium.org/2149053002