Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2138133002:
tools/SkShaper: factor shaping out of using_skia_and_harfbuzz (Closed)
|
Created:
4 years, 5 months ago by hal.canary Modified:
4 years, 5 months ago Reviewers:
bungeman-skia CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
Descriptiontools/SkShaper: factor shaping out of using_skia_and_harfbuzz
Make a clearer demarcation between shaping and layout.
also: refactor using_skia_and_harfbuzz; stop leaking
like a sieve.
Committed: https://skia.googlesource.com/skia/+/8a74f132398f107963fe1b27fb54b63a008e67dd
Patch Set 1 : 2016-07-11 (Monday) 14:22:40 EDT #Patch Set 2 : 2016-07-11 (Monday) 15:42:21 EDT #
Messages
Total messages: 28 (24 generated)
Description was changed from ========== tools/using_skia_and_harfbuzz: clean up BUG=skia: ========== to ========== tools/using_skia_and_harfbuzz: clean up BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138133002 ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== tools/using_skia_and_harfbuzz: clean up BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138133002 ========== to ========== tools/SkShaper: factor out of using_skia_and_harfbuzz also: refactor using_skia_and_harfbuzz. ==========
Description was changed from ========== tools/SkShaper: factor out of using_skia_and_harfbuzz also: refactor using_skia_and_harfbuzz. ========== to ========== tools/SkShaper: factor out of using_skia_and_harfbuzz also: refactor using_skia_and_harfbuzz. Also stop leaking like a sieve. ==========
Description was changed from ========== tools/SkShaper: factor out of using_skia_and_harfbuzz also: refactor using_skia_and_harfbuzz. Also stop leaking like a sieve. ========== to ========== tools/SkShaper: factor out of using_skia_and_harfbuzz also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== tools/SkShaper: factor out of using_skia_and_harfbuzz also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. ========== to ========== tools/SkShaper: factor out of using_skia_and_harfbuzz also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138133002 ==========
Description was changed from ========== tools/SkShaper: factor out of using_skia_and_harfbuzz also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138133002 ========== to ========== tools/SkShaper: factor out of using_skia_and_harfbuzz Make a clearer demarkation between shaping and layout. also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by halcanary@google.com
Description was changed from ========== tools/SkShaper: factor out of using_skia_and_harfbuzz Make a clearer demarkation between shaping and layout. also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. ========== to ========== tools/SkShaper: factor shaping out of using_skia_and_harfbuzz Make a clearer demarkation between shaping and layout. also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. ==========
Description was changed from ========== tools/SkShaper: factor shaping out of using_skia_and_harfbuzz Make a clearer demarkation between shaping and layout. also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. ========== to ========== tools/SkShaper: factor shaping out of using_skia_and_harfbuzz Make a clearer demarkation between shaping and layout. also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138133002 ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== tools/SkShaper: factor shaping out of using_skia_and_harfbuzz Make a clearer demarkation between shaping and layout. also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138133002 ========== to ========== tools/SkShaper: factor shaping out of using_skia_and_harfbuzz Make a clearer demarcation between shaping and layout. also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. ==========
Patchset #3 (id:40001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by halcanary@google.com
halcanary@google.com changed reviewers: + bungeman@google.com
PTAL
lgtm
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== tools/SkShaper: factor shaping out of using_skia_and_harfbuzz Make a clearer demarcation between shaping and layout. also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. ========== to ========== tools/SkShaper: factor shaping out of using_skia_and_harfbuzz Make a clearer demarcation between shaping and layout. also: refactor using_skia_and_harfbuzz; stop leaking like a sieve. Committed: https://skia.googlesource.com/skia/+/8a74f132398f107963fe1b27fb54b63a008e67dd ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://skia.googlesource.com/skia/+/8a74f132398f107963fe1b27fb54b63a008e67dd |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
