Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2138123003: DevTools: remove panel-based clipboard events dispatching. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove panel-based clipboard events dispatching. BUG=627306 Committed: https://crrev.com/f3f64b41f5d4a9c49a66e442f094db43eefc2e2e Cr-Commit-Position: refs/heads/master@{#405204}

Patch Set 1 #

Patch Set 2 : lcean #

Patch Set 3 : lcean #

Patch Set 4 : lcean #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -76 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 1 2 2 chunks +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 2 3 5 chunks +19 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 3 2 chunks +12 lines, -28 lines 4 comments Download

Messages

Total messages: 9 (3 generated)
pfeldman
4 years, 5 months ago (2016-07-12 02:29:21 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2138123003/diff/60001/third_party/WebKit/Source/devtools/front_end/main/Main.js File third_party/WebKit/Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/2138123003/diff/60001/third_party/WebKit/Source/devtools/front_end/main/Main.js#newcode502 third_party/WebKit/Source/devtools/front_end/main/Main.js:502: eventCopy["original"] = event; Can we use CustomEvent.detail for ...
4 years, 5 months ago (2016-07-12 03:21:55 UTC) #3
pfeldman
https://codereview.chromium.org/2138123003/diff/60001/third_party/WebKit/Source/devtools/front_end/main/Main.js File third_party/WebKit/Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/2138123003/diff/60001/third_party/WebKit/Source/devtools/front_end/main/Main.js#newcode502 third_party/WebKit/Source/devtools/front_end/main/Main.js:502: eventCopy["original"] = event; Did not work for me. https://codereview.chromium.org/2138123003/diff/60001/third_party/WebKit/Source/devtools/front_end/main/Main.js#newcode504 ...
4 years, 5 months ago (2016-07-12 20:56:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138123003/60001
4 years, 5 months ago (2016-07-13 15:19:38 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-13 17:11:17 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:12:35 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f3f64b41f5d4a9c49a66e442f094db43eefc2e2e
Cr-Commit-Position: refs/heads/master@{#405204}

Powered by Google App Engine
This is Rietveld 408576698