Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/browser/upgrade_detector.cc

Issue 2138103002: Change upgrade menu icon to use circle instead of round-rect & ensure the arrow is white (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use browser tools update icon for the upgrade menu Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/gfx/vector_icons/upgrade_menu_item.icon » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/upgrade_detector.h" 5 #include "chrome/browser/upgrade_detector.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "chrome/browser/chrome_notification_types.h" 9 #include "chrome/browser/chrome_notification_types.h"
10 #include "chrome/browser/lifetime/application_lifetime.h" 10 #include "chrome/browser/lifetime/application_lifetime.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 break; 52 break;
53 case UPGRADE_ANNOYANCE_HIGH: 53 case UPGRADE_ANNOYANCE_HIGH:
54 case UPGRADE_ANNOYANCE_SEVERE: 54 case UPGRADE_ANNOYANCE_SEVERE:
55 case UPGRADE_ANNOYANCE_CRITICAL: 55 case UPGRADE_ANNOYANCE_CRITICAL:
56 color = gfx::kGoogleRed700; 56 color = gfx::kGoogleRed700;
57 break; 57 break;
58 } 58 }
59 DCHECK_NE(gfx::kPlaceholderColor, color); 59 DCHECK_NE(gfx::kPlaceholderColor, color);
60 60
61 return gfx::Image( 61 return gfx::Image(
62 gfx::CreateVectorIcon(gfx::VectorIconId::UPGRADE_MENU_ITEM, 16, color)); 62 gfx::CreateVectorIcon(gfx::VectorIconId::BROWSER_TOOLS_UPDATE, color));
63 } 63 }
64 64
65 UpgradeDetector::UpgradeDetector() 65 UpgradeDetector::UpgradeDetector()
66 : upgrade_available_(UPGRADE_AVAILABLE_NONE), 66 : upgrade_available_(UPGRADE_AVAILABLE_NONE),
67 best_effort_experiment_updates_available_(false), 67 best_effort_experiment_updates_available_(false),
68 critical_experiment_updates_available_(false), 68 critical_experiment_updates_available_(false),
69 critical_update_acknowledged_(false), 69 critical_update_acknowledged_(false),
70 is_factory_reset_required_(false), 70 is_factory_reset_required_(false),
71 upgrade_notification_stage_(UPGRADE_ANNOYANCE_NONE), 71 upgrade_notification_stage_(UPGRADE_ANNOYANCE_NONE),
72 notify_upgrade_(false) { 72 notify_upgrade_(false) {
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 break; 133 break;
134 case ui::IDLE_STATE_ACTIVE: 134 case ui::IDLE_STATE_ACTIVE:
135 case ui::IDLE_STATE_UNKNOWN: 135 case ui::IDLE_STATE_UNKNOWN:
136 break; 136 break;
137 default: 137 default:
138 NOTREACHED(); // Need to add any new value above (either providing 138 NOTREACHED(); // Need to add any new value above (either providing
139 // automatic restart or show notification to user). 139 // automatic restart or show notification to user).
140 break; 140 break;
141 } 141 }
142 } 142 }
OLDNEW
« no previous file with comments | « no previous file | ui/gfx/vector_icons/upgrade_menu_item.icon » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698