Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2138103002:
Change upgrade menu icon to use circle instead of round-rect & ensure the arrow is white (Closed)
DescriptionThe app-menu button upgrade icon is a circle, while the menu item used a rounded rectangle. This ensures the menu image/icon is consistent with the button icon.
BUG=626915
Committed: https://crrev.com/721482c78489c2053013cad2043164d72b120aca
Cr-Commit-Position: refs/heads/master@{#405224}
Patch Set 1 #Patch Set 2 : Use browser tools update icon for the upgrade menu #
Messages
Total messages: 34 (15 generated)
Description was changed from ========== Change upgrade menu icon to use circle instead of round-rect. Ensure the arrow is white BUG= ========== to ========== Change upgrade menu icon to use circle instead of round-rect. Ensure the arrow is white BUG=626915 ==========
kylixrd@chromium.org changed reviewers: + estade@chromium.org
Description was changed from ========== Change upgrade menu icon to use circle instead of round-rect. Ensure the arrow is white BUG=626915 ========== to ========== The app-menu button upgrade icon is a circle, while the menu item used a rounded rectangle. This ensures the menu image/icon is consistent with the button icon. BUG=626915 ==========
this is now identical to browser_tools_update.icon. Why keep two copies?
On 2016/07/11 16:34:15, Evan Stade wrote: > this is now identical to browser_tools_update.icon. Why keep two copies? I was wondering if that'd come up :). Which should take precedence? The browser_tools_update.icon has a 1x version that is used for the app menu.
On 2016/07/11 16:54:52, kylix_rd wrote: > On 2016/07/11 16:34:15, Evan Stade wrote: > > this is now identical to browser_tools_update.icon. Why keep two copies? > > I was wondering if that'd come up :). Which should take precedence? The > browser_tools_update.icon has a 1x version that is used for the app menu. OK? Seems fine to use the dsf-appropriate version in both places.
Deleted upgrade_menu_item icon & now uses browser_tools_update icon for the menu's icon.
lgtm
The CQ bit was checked by kylixrd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by kylixrd@chromium.org
kylixrd@chromium.org changed reviewers: + thakis@chromium.org
thakis@, just need a quick look at upgrade_detector.cc.
lgtm
The CQ bit was checked by kylixrd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kylixrd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kylixrd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kylixrd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== The app-menu button upgrade icon is a circle, while the menu item used a rounded rectangle. This ensures the menu image/icon is consistent with the button icon. BUG=626915 ========== to ========== The app-menu button upgrade icon is a circle, while the menu item used a rounded rectangle. This ensures the menu image/icon is consistent with the button icon. BUG=626915 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== The app-menu button upgrade icon is a circle, while the menu item used a rounded rectangle. This ensures the menu image/icon is consistent with the button icon. BUG=626915 ========== to ========== The app-menu button upgrade icon is a circle, while the menu item used a rounded rectangle. This ensures the menu image/icon is consistent with the button icon. BUG=626915 Committed: https://crrev.com/721482c78489c2053013cad2043164d72b120aca Cr-Commit-Position: refs/heads/master@{#405224} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/721482c78489c2053013cad2043164d72b120aca Cr-Commit-Position: refs/heads/master@{#405224} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
