Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Unified Diff: runtime/lib/mirrors.cc

Issue 21381002: Implement mirror equality on the VM. Resolves issue 12026. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/mirrors.cc
===================================================================
--- runtime/lib/mirrors.cc (revision 25673)
+++ runtime/lib/mirrors.cc (working copy)
@@ -454,6 +454,13 @@
}
+DEFINE_NATIVE_ENTRY(MirrorReference_equals, 2) {
+ GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, a, arguments->NativeArgAt(0));
+ GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, b, arguments->NativeArgAt(1));
+ return Bool::Get(a.referent() == b.referent());
rmacnak 2013/07/31 18:38:01 Assert no GC? Identical_comparison doesn't.
siva 2013/08/01 00:05:06 Sure you can add a NoGCScope here if you want. On
+}
+
+
DEFINE_NATIVE_ENTRY(DeclarationMirror_metadata, 1) {
const MirrorReference& decl_ref =
MirrorReference::CheckedHandle(arguments->NativeArgAt(0));

Powered by Google App Engine
This is Rietveld 408576698